From: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
To: sfr@canb.auug.org.au, linux-next@vger.kernel.org
Cc: rdunlap@infradead.org, linux-kernel@vger.kernel.org,
Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
Subject: [PATCH] extcon: Fix build issues in ptn5150
Date: Mon, 28 Jan 2019 10:08:12 +0530 [thread overview]
Message-ID: <1548650292-15762-1-git-send-email-vijaikumar.kanagarajan@gmail.com> (raw)
In-Reply-To: <88f71303-575e-6680-a207-da102bda8ef2@infradead.org>
- extcon-ptn5150 driver uses gpio libraries
- Add GPIOLIB in depends section of Kconfig
Error:
-----
> CC drivers/extcon/extcon-ptn5150.o
> ../drivers/extcon/extcon-ptn5150.c: In function ‘ptn5150_irq_work’:
> ../drivers/extcon/extcon-ptn5150.c:130:5: error: implicit declaration of function ‘gpiod_set_value’ [-Werror=implicit-function-declaration]
> gpiod_set_value(info->vbus_gpiod, 0);
> ^
> ../drivers/extcon/extcon-ptn5150.c: In function ‘ptn5150_i2c_probe’:
> ../drivers/extcon/extcon-ptn5150.c:242:2: error: implicit declaration of function ‘devm_gpiod_get’ [-Werror=implicit-function-declaration]
> info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
> ^
> ../drivers/extcon/extcon-ptn5150.c:242:53: error: ‘GPIOD_IN’ undeclared (first use in this function)
> info->int_gpiod = devm_gpiod_get(&i2c->dev, "int", GPIOD_IN);
> ^
> ../drivers/extcon/extcon-ptn5150.c:242:53: note: each undeclared identifier is reported only once for each function it appears in
> ../drivers/extcon/extcon-ptn5150.c:252:2: error: implicit declaration of function ‘gpiod_direction_output’ [-Werror=implicit-function-declaration]
> ret = gpiod_direction_output(info->vbus_gpiod, 0);
> ^
> ../drivers/extcon/extcon-ptn5150.c:271:3: error: implicit declaration of function ‘gpiod_to_irq’ [-Werror=implicit-function-declaration]
> info->irq = gpiod_to_irq(info->int_gpiod);
-----
Signed-off-by: Vijai Kumar K <vijaikumar.kanagarajan@gmail.com>
---
drivers/extcon/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/extcon/Kconfig b/drivers/extcon/Kconfig
index b9cc027..330dd8b 100644
--- a/drivers/extcon/Kconfig
+++ b/drivers/extcon/Kconfig
@@ -116,7 +116,7 @@ config EXTCON_PALMAS
config EXTCON_PTN5150
tristate "NXP PTN5150 CC LOGIC USB EXTCON support"
- depends on I2C
+ depends on I2C && GPIOLIB
select REGMAP_I2C
help
Say Y here to enable support for USB peripheral and USB host
--
2.7.4
next prev parent reply other threads:[~2019-01-28 4:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-25 4:35 linux-next: Tree for Jan 25 Stephen Rothwell
2019-01-25 16:32 ` linux-next: Tree for Jan 25 (extcon/extcon-ptn5150.c) Randy Dunlap
2019-01-28 4:38 ` Vijai Kumar K [this message]
2019-01-28 7:10 ` [PATCH] extcon: Fix build issues in ptn5150 Vijai Kumar K
2019-01-28 21:26 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548650292-15762-1-git-send-email-vijaikumar.kanagarajan@gmail.com \
--to=vijaikumar.kanagarajan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®