From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754035AbYKRRZZ (ORCPT ); Tue, 18 Nov 2008 12:25:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752692AbYKRRZJ (ORCPT ); Tue, 18 Nov 2008 12:25:09 -0500 Received: from ey-out-2122.google.com ([74.125.78.27]:9448 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbYKRRZI (ORCPT ); Tue, 18 Nov 2008 12:25:08 -0500 Message-ID: <154e089b0811180925j7f35e87k22926d3c354b2c58@mail.gmail.com> Date: Tue, 18 Nov 2008 12:25:06 -0500 From: "Hannes Eder" To: "Takashi Iwai" , "Richard Holden" Subject: Re: [PATCH] sound: Fix warnings relating to ignored return value in snd_card_register Cc: "Jaroslav Kysela" , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <154e089b0811180759x4db4ba61k467fa2275710938f@mail.gmail.com> <154e089b0811180906r69099866vf0b80cd40d7e2cc7@mail.gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Do not ignore the return of 'device_create_file' in 'snd_card_register' and thereby fixing the following warnings: sound/core/init.c: In function 'snd_card_register': sound/core/init.c:640: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result sound/core/init.c:641: warning: ignoring return value of 'device_create_file', declared with attribute warn_unused_result Signed-off-by: Hannes Eder --- All warnings and errors reported by checkpatch.pl fixed. Thank you for your feedback. sound/core/init.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/sound/core/init.c b/sound/core/init.c index af1e407..0d5520c 100644 --- a/sound/core/init.c +++ b/sound/core/init.c @@ -637,8 +637,12 @@ int snd_card_register(struct snd_card *card) #endif #ifndef CONFIG_SYSFS_DEPRECATED if (card->card_dev) { - device_create_file(card->card_dev, &card_id_attrs); - device_create_file(card->card_dev, &card_number_attrs); + err = device_create_file(card->card_dev, &card_id_attrs); + if (err < 0) + return err; + err = device_create_file(card->card_dev, &card_number_attrs); + if (err < 0) + return err; } #endif return 0;