From: "Hannes Eder" <hannes@hanneseder.net>
To: "David Howells" <dhowells@redhat.com>,
"James Morris" <jmorris@namei.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [PATCH] CRED: fix sparse warnings
Date: Mon, 24 Nov 2008 22:14:43 +0100 [thread overview]
Message-ID: <154e089b0811241314t3291ea30w6268bb5b2b5c7c53@mail.gmail.com> (raw)
Impact: fix sparse warnings
Fix the following sparse warnings:
security/security.c:228:2: warning: returning void-valued expression
security/security.c:233:2: warning: returning void-valued expression
security/security.c:616:2: warning: returning void-valued expression
Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
security/security.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/security/security.c b/security/security.c
index 038ef04..f0d96a6 100644
--- a/security/security.c
+++ b/security/security.c
@@ -225,12 +225,12 @@ int security_bprm_check(struct linux_binprm *bprm)
void security_bprm_committing_creds(struct linux_binprm *bprm)
{
- return security_ops->bprm_committing_creds(bprm);
+ security_ops->bprm_committing_creds(bprm);
}
void security_bprm_committed_creds(struct linux_binprm *bprm)
{
- return security_ops->bprm_committed_creds(bprm);
+ security_ops->bprm_committed_creds(bprm);
}
int security_bprm_secureexec(struct linux_binprm *bprm)
@@ -613,7 +613,7 @@ int security_prepare_creds(struct cred *new, const
struct cred *old, gfp_t gfp)
void security_commit_creds(struct cred *new, const struct cred *old)
{
- return security_ops->cred_commit(new, old);
+ security_ops->cred_commit(new, old);
}
int security_kernel_act_as(struct cred *new, u32 secid)
--
1.5.6.3
next reply other threads:[~2008-11-24 21:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-24 21:14 Hannes Eder [this message]
2008-11-24 23:21 ` David Howells
2008-11-25 0:46 ` Hannes Eder
2008-11-25 0:56 ` Harvey Harrison
2008-11-25 6:39 ` Julia Lawall
2008-11-25 1:08 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0811241314t3291ea30w6268bb5b2b5c7c53@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®