From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754517AbZBNV5j (ORCPT ); Sat, 14 Feb 2009 16:57:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752001AbZBNV52 (ORCPT ); Sat, 14 Feb 2009 16:57:28 -0500 Received: from fg-out-1718.google.com ([72.14.220.159]:60822 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbZBNV51 (ORCPT ); Sat, 14 Feb 2009 16:57:27 -0500 MIME-Version: 1.0 In-Reply-To: <20090214213848.GF7648@localhost> References: <20090214210940.23489.95001.stgit@vmbox.hanneseder.net> <20090214211346.23489.96321.stgit@vmbox.hanneseder.net> <20090214212948.GE7648@localhost> <20090214213848.GF7648@localhost> Date: Sat, 14 Feb 2009 22:57:24 +0100 Message-ID: <154e089b0902141357x3af8b2adk223749ce11e976ef@mail.gmail.com> Subject: Re: [PATCH 08/43] drivers/net/ppp*.c: fix sparse warnings: fix signedness From: Hannes Eder To: Cyrill Gorcunov Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 14, 2009 at 10:38 PM, Cyrill Gorcunov wrote: > [Cyrill Gorcunov - Sun, Feb 15, 2009 at 12:29:48AM +0300] > | [Hannes Eder - Sat, Feb 14, 2009 at 10:13:52PM +0100] > | | Fix this sparse warnings: > | | drivers/net/ppp_generic.c:919:43: warning: incorrect type in argument 1 (different signedness) > | | drivers/net/pppoe.c:1195:43: warning: incorrect type in argument 1 (different signedness) > | | drivers/net/pppol2tp.c:2666:43: warning: incorrect type in argument 1 (different signedness) > | | > | | Signed-off-by: Hannes Eder > | ... > | > | Thanks Hannes, > | > | Acked-by: Cyrill Gorcunov > | > | - Cyrill - > > Btw I think the same fix could be applied on > drivers/net/tun.c (if you have time for :) This was fixed by this commit: commit 745417e20684e4951afcabfe74583a3884e54980 Author: Gerrit Renker Date: Sun Jan 4 17:14:46 2009 -0800 which is in the linux-next tree. BTW, how can I check from which tree this commit came into the linux-next tree? -Hannes