From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1758829AbZB0AyO@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758829AbZB0AyO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 Feb 2009 19:54:14 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753779AbZB0Ax4
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 26 Feb 2009 19:53:56 -0500
Received: from mail-fx0-f176.google.com ([209.85.220.176]:55713 "EHLO
	mail-fx0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753299AbZB0Ax4 convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 Feb 2009 19:53:56 -0500
MIME-Version: 1.0
In-Reply-To: <20090222000122.17557.75097.stgit@vmbox.hanneseder.net>
References: <20090221235706.17557.97714.stgit@vmbox.hanneseder.net>
	 <20090222000122.17557.75097.stgit@vmbox.hanneseder.net>
Date: Fri, 27 Feb 2009 01:53:52 +0100
Message-ID: <154e089b0902261653q4576b9c6v20b456834e4fac3@mail.gmail.com>
Subject: Re: [PATCH 03/16] drm: radeon: fix sparse warnings: Using plain 
	integer as NULL pointer
From: Hannes Eder <hannes@hanneseder.net>
To: trivial@kernel.org, Jesse Barnes <jbarnes@virtuousgeek.org>,
       dri-devel@lists.sourceforge.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

[Added To]

On Sun, Feb 22, 2009 at 1:01 AM, Hannes Eder <hannes@hanneseder.net> wrote:
> Fix this sparse warning:
>  drivers/gpu/drm/radeon/radeon_cp.c:1363:52: warning: Using plain integer as NULL pointer
>  drivers/gpu/drm/radeon/radeon_state.c:1983:61: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Hannes Eder <hannes@hanneseder.net>
> ---
>  drivers/gpu/drm/radeon/radeon_cp.c    |    2 +-
>  drivers/gpu/drm/radeon/radeon_state.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_cp.c b/drivers/gpu/drm/radeon/radeon_cp.c
> index 119e642..f5f4e96 100644
> --- a/drivers/gpu/drm/radeon/radeon_cp.c
> +++ b/drivers/gpu/drm/radeon/radeon_cp.c
> @@ -1360,7 +1360,7 @@ static int radeon_do_cleanup_cp(struct drm_device * dev)
>                if (dev_priv->gart_info.gart_table_location == DRM_ATI_GART_FB)
>                {
>                        drm_core_ioremapfree(&dev_priv->gart_info.mapping, dev);
> -                       dev_priv->gart_info.addr = 0;
> +                       dev_priv->gart_info.addr = NULL;
>                }
>        }
>        /* only clear to the start of flags */
> diff --git a/drivers/gpu/drm/radeon/radeon_state.c b/drivers/gpu/drm/radeon/radeon_state.c
> index 043293a..61e75bc 100644
> --- a/drivers/gpu/drm/radeon/radeon_state.c
> +++ b/drivers/gpu/drm/radeon/radeon_state.c
> @@ -1980,7 +1980,7 @@ static int alloc_surface(drm_radeon_surface_alloc_t *new,
>
>        /* find a virtual surface */
>        for (i = 0; i < 2 * RADEON_MAX_SURFACES; i++)
> -               if (dev_priv->virt_surfaces[i].file_priv == 0)
> +               if (dev_priv->virt_surfaces[i].file_priv == NULL)
>                        break;
>        if (i == 2 * RADEON_MAX_SURFACES) {
>                return -1;
>
>