From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758287AbZB0BCk (ORCPT ); Thu, 26 Feb 2009 20:02:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752309AbZB0BCb (ORCPT ); Thu, 26 Feb 2009 20:02:31 -0500 Received: from fg-out-1718.google.com ([72.14.220.152]:45030 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbZB0BCa convert rfc822-to-8bit (ORCPT ); Thu, 26 Feb 2009 20:02:30 -0500 MIME-Version: 1.0 In-Reply-To: <20090222000216.17557.92413.stgit@vmbox.hanneseder.net> References: <20090221235706.17557.97714.stgit@vmbox.hanneseder.net> <20090222000216.17557.92413.stgit@vmbox.hanneseder.net> Date: Fri, 27 Feb 2009 02:02:25 +0100 Message-ID: <154e089b0902261702r52432481q6a0561de9576ed71@mail.gmail.com> Subject: Re: [PATCH 06/16] MTD: tests: fix sparse warnings: Using plain integer as NULL pointer From: Hannes Eder To: trivial@kernel.org, Artem Bityutskiy Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Added To] On Sun, Feb 22, 2009 at 1:02 AM, Hannes Eder wrote: > Fix this sparse warnings: >  drivers/mtd/tests/mtd_oobtest.c:139:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:192:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:219:41: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:284:25: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:525:25: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:545:25: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:569:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:589:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:613:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:633:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:673:41: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_oobtest.c:701:33: warning: Using plain integer as NULL pointer >  drivers/mtd/tests/mtd_readtest.c:74:41: warning: Using plain integer as NULL pointer > > Signed-off-by: Hannes Eder > --- >  drivers/mtd/tests/mtd_oobtest.c  |   24 ++++++++++++------------ >  drivers/mtd/tests/mtd_readtest.c |    2 +- >  2 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/mtd/tests/mtd_oobtest.c b/drivers/mtd/tests/mtd_oobtest.c > index afbc3f8..a18e8d2 100644 > --- a/drivers/mtd/tests/mtd_oobtest.c > +++ b/drivers/mtd/tests/mtd_oobtest.c > @@ -136,7 +136,7 @@ static int write_eraseblock(int ebnum) >                ops.ooblen    = use_len; >                ops.oobretlen = 0; >                ops.ooboffs   = use_offset; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = writebuf; >                err = mtd->write_oob(mtd, addr, &ops); >                if (err || ops.oobretlen != use_len) { > @@ -189,7 +189,7 @@ static int verify_eraseblock(int ebnum) >                ops.ooblen    = use_len; >                ops.oobretlen = 0; >                ops.ooboffs   = use_offset; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = readbuf; >                err = mtd->read_oob(mtd, addr, &ops); >                if (err || ops.oobretlen != use_len) { > @@ -216,7 +216,7 @@ static int verify_eraseblock(int ebnum) >                        ops.ooblen    = mtd->ecclayout->oobavail; >                        ops.oobretlen = 0; >                        ops.ooboffs   = 0; > -                       ops.datbuf    = 0; > +                       ops.datbuf    = NULL; >                        ops.oobbuf    = readbuf; >                        err = mtd->read_oob(mtd, addr, &ops); >                        if (err || ops.oobretlen != mtd->ecclayout->oobavail) { > @@ -281,7 +281,7 @@ static int verify_eraseblock_in_one_go(int ebnum) >        ops.ooblen    = len; >        ops.oobretlen = 0; >        ops.ooboffs   = 0; > -       ops.datbuf    = 0; > +       ops.datbuf    = NULL; >        ops.oobbuf    = readbuf; >        err = mtd->read_oob(mtd, addr, &ops); >        if (err || ops.oobretlen != len) { > @@ -522,7 +522,7 @@ static int __init mtd_oobtest_init(void) >        ops.ooblen    = 1; >        ops.oobretlen = 0; >        ops.ooboffs   = mtd->ecclayout->oobavail; > -       ops.datbuf    = 0; > +       ops.datbuf    = NULL; >        ops.oobbuf    = writebuf; >        printk(PRINT_PREF "attempting to start write past end of OOB\n"); >        printk(PRINT_PREF "an error is expected...\n"); > @@ -542,7 +542,7 @@ static int __init mtd_oobtest_init(void) >        ops.ooblen    = 1; >        ops.oobretlen = 0; >        ops.ooboffs   = mtd->ecclayout->oobavail; > -       ops.datbuf    = 0; > +       ops.datbuf    = NULL; >        ops.oobbuf    = readbuf; >        printk(PRINT_PREF "attempting to start read past end of OOB\n"); >        printk(PRINT_PREF "an error is expected...\n"); > @@ -566,7 +566,7 @@ static int __init mtd_oobtest_init(void) >                ops.ooblen    = mtd->ecclayout->oobavail + 1; >                ops.oobretlen = 0; >                ops.ooboffs   = 0; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = writebuf; >                printk(PRINT_PREF "attempting to write past end of device\n"); >                printk(PRINT_PREF "an error is expected...\n"); > @@ -586,7 +586,7 @@ static int __init mtd_oobtest_init(void) >                ops.ooblen    = mtd->ecclayout->oobavail + 1; >                ops.oobretlen = 0; >                ops.ooboffs   = 0; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = readbuf; >                printk(PRINT_PREF "attempting to read past end of device\n"); >                printk(PRINT_PREF "an error is expected...\n"); > @@ -610,7 +610,7 @@ static int __init mtd_oobtest_init(void) >                ops.ooblen    = mtd->ecclayout->oobavail; >                ops.oobretlen = 0; >                ops.ooboffs   = 1; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = writebuf; >                printk(PRINT_PREF "attempting to write past end of device\n"); >                printk(PRINT_PREF "an error is expected...\n"); > @@ -630,7 +630,7 @@ static int __init mtd_oobtest_init(void) >                ops.ooblen    = mtd->ecclayout->oobavail; >                ops.oobretlen = 0; >                ops.ooboffs   = 1; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = readbuf; >                printk(PRINT_PREF "attempting to read past end of device\n"); >                printk(PRINT_PREF "an error is expected...\n"); > @@ -670,7 +670,7 @@ static int __init mtd_oobtest_init(void) >                        ops.ooblen    = sz; >                        ops.oobretlen = 0; >                        ops.ooboffs   = 0; > -                       ops.datbuf    = 0; > +                       ops.datbuf    = NULL; >                        ops.oobbuf    = writebuf; >                        err = mtd->write_oob(mtd, addr, &ops); >                        if (err) > @@ -698,7 +698,7 @@ static int __init mtd_oobtest_init(void) >                ops.ooblen    = mtd->ecclayout->oobavail * 2; >                ops.oobretlen = 0; >                ops.ooboffs   = 0; > -               ops.datbuf    = 0; > +               ops.datbuf    = NULL; >                ops.oobbuf    = readbuf; >                err = mtd->read_oob(mtd, addr, &ops); >                if (err) > diff --git a/drivers/mtd/tests/mtd_readtest.c b/drivers/mtd/tests/mtd_readtest.c > index 645e77f..79fc453 100644 > --- a/drivers/mtd/tests/mtd_readtest.c > +++ b/drivers/mtd/tests/mtd_readtest.c > @@ -71,7 +71,7 @@ static int read_eraseblock_by_page(int ebnum) >                        ops.ooblen    = mtd->oobsize; >                        ops.oobretlen = 0; >                        ops.ooboffs   = 0; > -                       ops.datbuf    = 0; > +                       ops.datbuf    = NULL; >                        ops.oobbuf    = oobbuf; >                        ret = mtd->read_oob(mtd, addr, &ops); >                        if (ret || ops.oobretlen != mtd->oobsize) { > >