From: Hannes Eder <hannes@hanneseder.net>
To: Florian Fainelli <florian@openwrt.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] vlynq: remove duplicated #include
Date: Wed, 8 Jul 2009 01:54:14 +0200 [thread overview]
Message-ID: <154e089b0907071654o46145717h17ac558aa4d524e0@mail.gmail.com> (raw)
In-Reply-To: <200907072336.14767.florian@openwrt.org>
On Tue, Jul 7, 2009 at 23:36, Florian Fainelli<florian@openwrt.org> wrote:
> Remove duplicated #include('s) in drivers/vlynq/vlynq.c
The following little script catches more of these issues, though it
might be a bit fragile:
#!/bin/bash
find . -name "*.c" | \
while read file; do
dblinc=$(grep "^#include <" $file | sort | uniq -c | grep -v "^ 1 ")
[ "$dblinc" != "" ] && echo $file: $dblinc
done
when ran from the linux-2.6 src tree, the output is something like
(lines starting with '#' are my annotations):
./mm/slab.c: 3 #include <linux/kmalloc_sizes.h>
# this is a false positive
./mm/slqb.c: 2 #include <linux/seq_file.h>
# I did not look a this one
./mm/shmem.c: 2 #include <linux/vfs.h>
# this is a hit
# the rest (about 50 hits) skipped
Do you want to investigate this issues?
Cheers,
Hannes
next prev parent reply other threads:[~2009-07-07 23:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 21:36 Florian Fainelli
2009-07-07 23:54 ` Hannes Eder [this message]
2009-07-08 6:40 ` Florian Fainelli
2009-07-08 11:50 ` Robert P. J. Day
2009-07-08 12:28 ` Hannes Eder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154e089b0907071654o46145717h17ac558aa4d524e0@mail.gmail.com \
--to=hannes@hanneseder.net \
--cc=akpm@linux-foundation.org \
--cc=florian@openwrt.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®