From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91F24C43381 for ; Wed, 20 Feb 2019 17:38:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6723620880 for ; Wed, 20 Feb 2019 17:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550684307; bh=4UuXoCd9eA+34QtQW5LiwBnEFhpo5I7ZEvbgOzvyEvg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=h8NTEsM6toSKQbfztZWVrN0pY+DuN3YK2F4qnaaEk6/u0nBEoxs55FtzTsntZkSyX 6h+nq+nXZTK5o/1vMGKwJWcXZVIaTpza/2gpN4vw7qgpN7Si7ZHX9q53dZULho7cLT td5aK9QVHwo79Q6XvfQOYxgF+jT8ehMFR2dlLyfo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfBTRi0 (ORCPT ); Wed, 20 Feb 2019 12:38:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:40314 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725798AbfBTRiZ (ORCPT ); Wed, 20 Feb 2019 12:38:25 -0500 Received: from tzanussi-mobl (c-98-220-238-81.hsd1.il.comcast.net [98.220.238.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61C982083E; Wed, 20 Feb 2019 17:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1550684304; bh=4UuXoCd9eA+34QtQW5LiwBnEFhpo5I7ZEvbgOzvyEvg=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=f71NdnjzaTLAt5qnwzbNlQafL87oA3ITneANdAESaZg+TkjjuVILBV6fzUwAz122L qlysWD8zdAjLblFgyxX8H/O/mIcz0r3gCoINUolflw9xMJNOkZ66Jm1syQt3Oimb7H Rn6HiyQXWMPw2E8+5Ow0+e6nVDFkhxp0RE2NlEQQ= Message-ID: <1550684302.2027.6.camel@kernel.org> Subject: Re: [PATCH v15 15/15] tracing: Add hist trigger action 'expected fail' test case From: Tom Zanussi To: Steven Rostedt Cc: tglx@linutronix.de, mhiramat@kernel.org, namhyung@kernel.org, vedang.patel@intel.com, bigeasy@linutronix.de, joel@joelfernandes.org, mathieu.desnoyers@efficios.com, julia@ni.com, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org Date: Wed, 20 Feb 2019 11:38:22 -0600 In-Reply-To: <20190220121748.7aa83459@gandalf.local.home> References: <1790bf93e01dbdfa1b4af945f42147d92bd565aa.1550100284.git.tom.zanussi@linux.intel.com> <20190220121748.7aa83459@gandalf.local.home> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Steve, On Wed, 2019-02-20 at 12:17 -0500, Steven Rostedt wrote: > On Wed, 13 Feb 2019 17:42:55 -0600 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying that basic action combinations fail as > > expected. > > > > Hi Tom, > > This test appears to fail: > > # echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' > >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger > -bash: echo: write error: Invalid argument > > # cat /sys/kernel/debug/tracing/events/sched/sched_waking/hist > > ERROR: action parsing: Handler doesn't support action: save > Last command: keys=comm:onmatch(sched.sched_wakeup).save(comm,prio) > > > Is the "save" feature implemented here? It's in the README too. > Should > it be removed? > The "save" feature is implemented, but it's not currently supported with onmatch(), which is why it fails, and is used in the xfail test, since it's expected to. So, in this case, the command fails, which means the xfail test actually passed. ;-) There are other tests in the inter-event testcases that use save() but with onmax() and onchange(), and they pass. Hope that explains things in this case, Tom > -- Steve > > > Signed-off-by: Tom Zanussi > > --- > > .../inter-event/trigger-action-hist-xfail.tc | 30 > > ++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 > > tools/testing/selftests/ftrace/test.d/trigger/inter-event/trigger- > > action-hist-xfail.tc > > > > diff --git a/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-action-hist-xfail.tc > > b/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-action-hist-xfail.tc > > new file mode 100644 > > index 000000000000..1221240f8cf6 > > --- /dev/null > > +++ b/tools/testing/selftests/ftrace/test.d/trigger/inter- > > event/trigger-action-hist-xfail.tc > > @@ -0,0 +1,30 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > +# description: event trigger - test inter-event histogram trigger > > expected fail actions > > + > > +fail() { #msg > > + echo $1 > > + exit_fail > > +} > > + > > +if [ ! -f set_event ]; then > > + echo "event tracing is not supported" > > + exit_unsupported > > +fi > > + > > +if [ ! -f snapshot ]; then > > + echo "snapshot is not supported" > > + exit_unsupported > > +fi > > + > > +grep -q "snapshot()" README || exit_unsupported # version issue > > + > > +echo "Test expected snapshot action failure" > > + > > +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).snapshot()' >> > > /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && > > exit_fail > > + > > +echo "Test expected save action failure" > > + > > +echo 'hist:keys=comm:onmatch(sched.sched_wakeup).save(comm,prio)' > > >> /sys/kernel/debug/tracing/events/sched/sched_waking/trigger && > > exit_fail > > + > > +exit_xfail > >