mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Chen <vincentc@andestech.com>
To: <palmer@sifive.com>, <aou@eecs.berkeley.edu>,
	<ebiederm@xmission.com>, <jimw@sifive.com>, <arnd@arndb.de>,
	<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <deanbo422@gmail.com>, <vincentc@andestech.com>
Subject: [PATCH 2/3] riscv: Support BUG() in kernel module
Date: Thu, 28 Feb 2019 18:31:30 +0800	[thread overview]
Message-ID: <1551349891-22683-3-git-send-email-vincentc@andestech.com> (raw)
In-Reply-To: <1551349891-22683-1-git-send-email-vincentc@andestech.com>

The kernel module is loaded into vmalloc region which is located below
to the PAGE_OFFSET. Hence the condition, pc < PAGE_OFFSET, in the
is_valid_bugaddr() will filter out all trap exceptions triggered
by kernel module. To support BUG() in kernel module, the condition is
changed to pc < VMALLOC_START.

Signed-off-by: Vincent Chen <vincentc@andestech.com>
---
 arch/riscv/kernel/traps.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c
index deae0e5..dee0e5e 100644
--- a/arch/riscv/kernel/traps.c
+++ b/arch/riscv/kernel/traps.c
@@ -144,7 +144,7 @@ int is_valid_bugaddr(unsigned long pc)
 {
 	bug_insn_t insn;
 
-	if (pc < PAGE_OFFSET)
+	if (pc < VMALLOC_START)
 		return 0;
 	if (probe_kernel_address((bug_insn_t *)pc, insn))
 		return 0;
-- 
1.7.1


  parent reply	other threads:[~2019-02-28 10:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-28 10:31 [PATCH 0/3] riscv: Fix debug instruction check and support trap-based WARN() Vincent Chen
2019-02-28 10:31 ` [PATCH 1/3] riscv: Add the support for c.ebreak check in is_valid_bugaddr() Vincent Chen
2019-02-28 10:31 ` Vincent Chen [this message]
2019-02-28 10:31 ` [PATCH 3/3] riscv: Make WARN() related functions able to trigger a trap exception Vincent Chen
2019-03-04 20:35 ` [PATCH 0/3] riscv: Fix debug instruction check and support trap-based WARN() Palmer Dabbelt
2019-03-05  0:21   ` Vincent Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1551349891-22683-3-git-send-email-vincentc@andestech.com \
    --to=vincentc@andestech.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=arnd@arndb.de \
    --cc=deanbo422@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=jimw@sifive.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®