From: Vincent Chen <vincentc@andestech.com>
To: <palmer@sifive.com>, <aou@eecs.berkeley.edu>,
<ebiederm@xmission.com>, <jimw@sifive.com>,
<linux-riscv@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Cc: <deanbo422@gmail.com>, <vincentc@andestech.com>
Subject: [PATCH v2 0/3] riscv: Support trap-based WARN() and fix bug in do_trap_break
Date: Tue, 5 Mar 2019 11:23:32 +0800 [thread overview]
Message-ID: <1551756215-22299-1-git-send-email-vincentc@andestech.com> (raw)
Changes in v2:
- Remove unnecessary non-functional diff
- Rearrange the order of the patches
- Edit the commit description
The trap-based WARN() will help developers to analyze the cause of WARN()
because if the debugger is connected, the control flow will be transferred
to debugging environment.
BUG() is currently not working properly. When the C extension is supported,
the assembler translates the "ebreak" to "c.ebreak" opcode. Hence the trap
is possibly triggered by "c.ebreak" instead of expected the "ebreak". This
will cause the check mechanism in is_valid_bugaddr(bugaddr) to think that
the trap triggered by "c.ebreak" occurs in an invalidate bug address. This
patch set will add "c.ebreak" into the check mechanism. In addition, BUG()
is also unable to work in the kernel module due to an inappropriate
condition in is_valid_bugaddr().
Vincent Chen (3):
riscv: support trap-based WARN()
riscv: Add the support for c.ebreak check in is_valid_bugaddr()
riscv: Support BUG() in kernel module
arch/riscv/include/asm/bug.h | 34 ++++++++++++++++++++++++----------
arch/riscv/kernel/traps.c | 22 ++++++++++++++++++----
2 files changed, 42 insertions(+), 14 deletions(-)
next reply other threads:[~2019-03-05 3:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 3:23 Vincent Chen [this message]
2019-03-05 3:23 ` [PATCH v2 1/3] riscv: support trap-based WARN() Vincent Chen
2019-03-05 3:23 ` [PATCH v2 2/3] riscv: Add the support for c.ebreak check in is_valid_bugaddr() Vincent Chen
2019-03-05 3:23 ` [PATCH v2 3/3] riscv: Support BUG() in kernel module Vincent Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551756215-22299-1-git-send-email-vincentc@andestech.com \
--to=vincentc@andestech.com \
--cc=aou@eecs.berkeley.edu \
--cc=deanbo422@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jimw@sifive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®