From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 145BCC43381 for ; Mon, 11 Mar 2019 05:33:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF02E2075C for ; Mon, 11 Mar 2019 05:33:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726077AbfCKFdQ (ORCPT ); Mon, 11 Mar 2019 01:33:16 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:8173 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725823AbfCKFdQ (ORCPT ); Mon, 11 Mar 2019 01:33:16 -0400 X-UUID: b57cb2a48c9746af95c7555c4a6958ec-20190311 X-UUID: b57cb2a48c9746af95c7555c4a6958ec-20190311 Received: from mtkcas34.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 785341383; Mon, 11 Mar 2019 13:33:05 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 11 Mar 2019 13:33:04 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 11 Mar 2019 13:33:03 +0800 Message-ID: <1552282383.10179.21.camel@mhfsdcap03> Subject: Re: [PATCH 1/5] dt-bindings: connector: add optional properties for Type-B From: Chunfeng Yun To: Hans de Goede CC: Rob Herring , Greg Kroah-Hartman , Heikki Krogerus , Mark Rutland , Matthias Brugger , Adam Thomson , Li Jun , "Badhri Jagan Sridharan" , Andy Shevchenko , Min Guo , , , , , Date: Mon, 11 Mar 2019 13:33:03 +0800 In-Reply-To: <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> References: <1552025622-15582-1-git-send-email-chunfeng.yun@mediatek.com> <1552025622-15582-2-git-send-email-chunfeng.yun@mediatek.com> <693b11e7-fa9e-ab1f-561a-beb758b1872f@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 2019-03-08 at 13:07 +0100, Hans de Goede wrote: > Hi, > > On 08-03-19 07:13, Chunfeng Yun wrote: > > Add id-gpios, vbus-gpios, vbus-supply and pinctrl properties for > > usb-b-connector > > > > Signed-off-by: Chunfeng Yun > > --- > > .../devicetree/bindings/connector/usb-connector.txt | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/connector/usb-connector.txt b/Documentation/devicetree/bindings/connector/usb-connector.txt > > index a9a2f2fc44f2..7a07b0f4f973 100644 > > --- a/Documentation/devicetree/bindings/connector/usb-connector.txt > > +++ b/Documentation/devicetree/bindings/connector/usb-connector.txt > > @@ -17,6 +17,16 @@ Optional properties: > > - self-powered: Set this property if the usb device that has its own power > > source. > > > > +Optional properties for usb-b-connector: > > +- id-gpios: gpio for USB ID pin. > > What about boards where the ID pin is *not* connected to a GPIO, > but e.g. to a special pin on the PMIC which can also detect > an ACA adapter ? Currently this case is handled by extcon > drivers, but we have no way to set e.g. vbus-supply for the > connector. Maybe in this case the usb-connector node should > be a child of the PMIC node ? Yes, it would be, PMIC is in charger of detecting the status of ID pin > > And in many cases there also is a mux to switch the datalines > between the host and device(gadget) controllers, how should > that be described in this model? See the new usb-role-switch > code under drivers/usb/roles > > In some cases the mux is controlled through a gpio, so we > may want to add a "mux-gpios" here in which case we also > need to define what 0/1 means. I'm not sure, the mux seems not belong to this connector, and may need another driver to register usb-role-switch, similar to: [v2,2/2] usb: typec: add typec switch via GPIO control https://patchwork.kernel.org/patch/10834327/ > > > +- vbus-gpios: gpio for USB VBUS pin. > > + see gpio/gpio.txt. > > +- vbus-supply: reference to the VBUS regulator, needed when supports > > + dual-role mode. > > I think this needs some text that there can be either a vbus-gpio or > a vbus-supply. Oh wait reading: > > https://patchwork.kernel.org/patch/10819377/ > > I see that this GPIO is for detecting vbus presence, not for driving/enabling > 5v to Vbus from the board, that needs to be described more clearly. Ok Thanks a lot > > > +- pinctrl-names : a pinctrl state named "default" is optional > > +- pinctrl-0 : pin control group > > + see pinctrl/pinctrl-bindings.txt > > + > > Optional properties for usb-c-connector: > > - power-role: should be one of "source", "sink" or "dual"(DRP) if typec > > connector has power support. > > > > > Regards, > > Hans