mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Mosberger <davidm@napali.hpl.hp.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: davidm@hpl.hp.com, Marcelo Tosatti <marcelo@conectiva.com.br>,
	Andrew Morton <akpm@zip.com.au>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] generic show_stack facility
Date: Fri, 29 Mar 2002 09:08:01 -0800	[thread overview]
Message-ID: <15524.40817.306204.292158@napali.hpl.hp.com> (raw)
In-Reply-To: <20020329160618.A25410@phoenix.infradead.org>

>>>>> On Fri, 29 Mar 2002 16:06:18 +0000, Christoph Hellwig <hch@infradead.org> said:

  Christoph> On Fri, Mar 29, 2002 at 07:46:07AM -0800, David Mosberger
  Christoph> wrote:
  >> Christoph, why do you think the prototype for ia64 is different?

  Christoph> I have stopped to wonder why ia64 does things
  Christoph> differently.

You might want to reconsider that stance.  It could open your mind. ;-)

BTW: this is not at all an ia64-specific issue.  It applies to any
arch that doesn't maintain a frame pointer on the stack.  Basic
compiler technology.

  >> It's because it *has to be*.  In general, you can't do a
  >> backtrace without having the full (preserved) state of the CPU at
  >> the point of which the backtrace begins.

  Christoph> So your suggestion is to move the other architectures to
  Christoph> the ia64 prototype or to not have an
  Christoph> architecture-independand stack-traceback facility at all?

I haven't done such an investigation.  I believe the ia64 prototype is
reasonable and probably implementable on all platforms that can unwind
the stack in the first place, but before making a change to the stable
kernel API, I'd think someone would have to investigate this a bit
further.

One issue to consider is whether it's safe to call the routine on a
task that is running on another processor.  The ia64 implementation
can handle this gracefully, because it's sometimes better to print a
meaningless (garbled) stack trace than to make provably certain that
the task won't be running on any other CPU.  A related question is
whether the routine can be called with interrupts masked.

My sense is this is something that should be considered for 2.5 first.

	--david

  reply	other threads:[~2002-03-29 17:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-03-29 15:23 Christoph Hellwig
2002-03-29 15:46 ` David Mosberger
2002-03-29 16:06   ` Christoph Hellwig
2002-03-29 17:08     ` David Mosberger [this message]
2002-03-29 17:16       ` arjan
2002-03-29 18:25         ` David Mosberger
2002-03-30 10:06           ` Kai Henningsen
2002-03-29 17:36       ` Andrew Morton
2002-03-29 18:26         ` David Mosberger
2002-03-29 18:34         ` Christoph Hellwig
2002-03-29 18:41           ` Andrew Morton
2002-03-30  3:05 Keith Owens
2002-03-30  3:31 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15524.40817.306204.292158@napali.hpl.hp.com \
    --to=davidm@napali.hpl.hp.com \
    --cc=akpm@zip.com.au \
    --cc=davidm@hpl.hp.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®