From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10DCAC43381 for ; Mon, 18 Mar 2019 16:40:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DF28C20854 for ; Mon, 18 Mar 2019 16:40:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727747AbfCRQk5 (ORCPT ); Mon, 18 Mar 2019 12:40:57 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:40337 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726806AbfCRQkz (ORCPT ); Mon, 18 Mar 2019 12:40:55 -0400 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1h5vJj-0006QY-0e; Mon, 18 Mar 2019 17:40:51 +0100 Message-ID: <1552927250.7558.10.camel@pengutronix.de> Subject: Re: [PATCH 1/5] reset: add acquired/released state for exclusive reset controls From: Philipp Zabel To: Thierry Reding Cc: Jonathan Hunter , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 18 Mar 2019 17:40:50 +0100 In-Reply-To: <20190318091216.GB14465@ulmo> References: <20190221152557.8534-1-thierry.reding@gmail.com> <20190221152858.GA8652@ulmo> <20190318091216.GB14465@ulmo> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thierry, On Mon, 2019-03-18 at 10:12 +0100, Thierry Reding wrote: > On Thu, Feb 21, 2019 at 04:28:58PM +0100, Thierry Reding wrote: > > On Thu, Feb 21, 2019 at 04:25:53PM +0100, Thierry Reding wrote: > > > From: Philipp Zabel > > > > > > There are cases where a driver needs explicit control over a reset line > > > that is exclusively conneted to its device, but this control has to be > > > temporarily handed over to the power domain controller to handle reset > > > requirements during power transitions. > > > Allow multiple exclusive reset controls to be requested in 'released' > > > state for the same physical reset line, only one of which can be > > > acquired at the same time. > > > > > > Signed-off-by: Philipp Zabel > > > Signed-off-by: Thierry Reding > > > --- > > > drivers/reset/core.c | 139 ++++++++++++++++++++++++++++++++++++++---- > > > include/linux/reset.h | 93 ++++++++++++++++++++++------ > > > 2 files changed, 200 insertions(+), 32 deletions(-) > > > > Hi Philipp, > > > > the bulk of this is unchanged relative to what you had posted > > originally. I squashed in the few things that we had already discussed > > earlier (EINVAL -> EPERM) and a couple of minor fixes for issues that I > > found while working with this. > > > > Attached is my fixup patch which contains all the changes I made on top > > of your version and that I squashed into this. > > > > Thierry > > Hi Philipp, > > do you have any further comments on this series? Sorry for the delay, I'll have a closer look tomorrow. I obviously don't disagree on the implementation and I appreciate the added documentation. As for how to merge this, would you be fine with me providing a stable branch that contains the first three patches? That could then go into both reset/next and tegra trees. regards Philipp