From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A368C43381 for ; Thu, 21 Mar 2019 10:12:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5467F218B0 for ; Thu, 21 Mar 2019 10:12:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725985AbfCUKLy (ORCPT ); Thu, 21 Mar 2019 06:11:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:55332 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727986AbfCUKLx (ORCPT ); Thu, 21 Mar 2019 06:11:53 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 0E01CB0BA; Thu, 21 Mar 2019 10:11:52 +0000 (UTC) Message-ID: <1553163110.5084.11.camel@suse.de> Subject: Re: [PATCH v2] efi: Unify dmi setup code over architectures arm/arm64, io64 and x86 From: Jean Delvare To: Ard Biesheuvel , Robert Richter Cc: Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "x86@kernel.org" , Marcin Benka , "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-efi@vger.kernel.org" Date: Thu, 21 Mar 2019 11:11:50 +0100 In-Reply-To: References: <20190320130502.16667-1-rrichter@marvell.com> <20190320131607.vgst3r7ynha55ikw@rric.localdomain> <20190320152240.2eun63wqkbqmuqkg@rric.localdomain> <20190321093920.beng2d3tbfvydbud@rric.localdomain> Organization: Suse Linux Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-03-21 at 10:51 +0100, Ard Biesheuvel wrote: > On Thu, 21 Mar 2019 at 10:39, Robert Richter wrote: > > > > On 20.03.19 23:02:09, Ard Biesheuvel wrote: > > > On Wed, 20 Mar 2019 at 16:23, Robert Richter wrote: > > > > > > > > On 20.03.19 14:16:07, Robert Richter wrote: > > > > > On 20.03.19 13:05:37, Robert Richter wrote: > > > > > > @@ -167,6 +167,7 @@ static int __init arm_dmi_init(void) > > > > > > * itself, depends on dmi_scan_machine() having been called already. > > > > > > */ > > > > > > dmi_scan_machine(); > > > > > > + dmi_memdev_walk(); > > > > > > if (dmi_available) > > > > > > dmi_set_dump_stack_arch_desc(); > > > > > > return 0; > > > > > > > > > > After > > > > > > > > > > [PATCH] efi/arm: Show SMBIOS bank/device location in cper and > > > > > ghes error logs > > > > > > > > > > wents in for arm/arm64, we can unify the code. See patch below. > > > > > > > > V2 with the fix in arm_dmi_init() below. > > > > > > > > -Robert > > > > > > > > > > > > -- >8 -- > > > > From: Robert Richter > > > > Subject: [PATCH v2] efi: Unify dmi setup code over architectures arm/arm64, > > > > io64 and x86 > > > > > > > > All architectures (arm/arm64, io64 and x86) do the same here, so unify > > > > the code. > > > > > > > > Note: We do not need to call dump_stack_set_arch_desc() in case of > > > > !dmi_available. Both strings, dmi_ids_string and dump_stack_arch_ > > > > desc_str are initialized zero and thus nothing would change. > > > > > > > > > > I don't understand the last sentence - we do not need to call > > > dump_stack_set_arch_desc() when !dmi_available, but we do so anyway, > > > right? Doesn't that wipe the arch description we set based on the DT > > > machine name? > > > > No, in dmi_setup() we exit early when !dmi_available. So for arm/arm64 > > nothing changed. But for x86 and ia64 we no longer call dump_stack_ > > set_arch_desc() in this case. This is ok since both strings, > > dmi_ids_string and dump_stack_arch_desc_str, are initialized zero and > > copying one to the other does not change anything. > > > > Ah, of course. Apologies for not reading more carefully. > > I'll take this patch via the EFI tree. I like the idea. If this is not going through my tree then: Reviewed-by: Jean Delvare -- Jean Delvare SUSE L3 Support