From: Parav Pandit <parav@mellanox.com>
To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
kwankhede@nvidia.com, alex.williamson@redhat.com
Cc: parav@mellanox.com
Subject: [PATCH 6/8] vfio/mdev: Follow correct remove sequence
Date: Fri, 22 Mar 2019 18:20:33 -0500 [thread overview]
Message-ID: <1553296835-37522-7-git-send-email-parav@mellanox.com> (raw)
In-Reply-To: <1553296835-37522-1-git-send-email-parav@mellanox.com>
mdev_remove_sysfs_files() should follow exact mirror sequence of a
create, similar to what is followed in error unwinding path of
mdev_create_sysfs_files().
Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
Signed-off-by: Parav Pandit <parav@mellanox.com>
---
drivers/vfio/mdev/mdev_sysfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vfio/mdev/mdev_sysfs.c b/drivers/vfio/mdev/mdev_sysfs.c
index ce5dd21..c782fa9 100644
--- a/drivers/vfio/mdev/mdev_sysfs.c
+++ b/drivers/vfio/mdev/mdev_sysfs.c
@@ -280,7 +280,7 @@ int mdev_create_sysfs_files(struct device *dev, struct mdev_type *type)
void mdev_remove_sysfs_files(struct device *dev, struct mdev_type *type)
{
+ sysfs_remove_files(&dev->kobj, mdev_device_attrs);
sysfs_remove_link(&dev->kobj, "mdev_type");
sysfs_remove_link(type->devices_kobj, dev_name(dev));
- sysfs_remove_files(&dev->kobj, mdev_device_attrs);
}
--
1.8.3.1
next prev parent reply other threads:[~2019-03-22 23:21 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-22 23:20 [PATCH 0/8] vfio/mdev: Improve vfio/mdev core module Parav Pandit
2019-03-22 23:20 ` [PATCH 1/8] vfio/mdev: Fix to not do put_device on device_register failure Parav Pandit
2019-03-25 11:48 ` Maxim Levitsky
2019-03-25 18:17 ` Kirti Wankhede
2019-03-25 19:21 ` Alex Williamson
2019-03-25 21:11 ` Parav Pandit
2019-03-22 23:20 ` [PATCH 2/8] vfio/mdev: Avoid release parent reference during error path Parav Pandit
2019-03-25 11:49 ` Maxim Levitsky
2019-03-25 18:27 ` Kirti Wankhede
2019-03-22 23:20 ` [PATCH 3/8] vfio/mdev: Removed unused kref Parav Pandit
2019-03-25 11:50 ` Maxim Levitsky
2019-03-25 18:41 ` Kirti Wankhede
2019-03-22 23:20 ` [PATCH 4/8] vfio/mdev: Drop redundant extern for exported symbols Parav Pandit
2019-03-25 11:56 ` Maxim Levitsky
2019-03-25 19:07 ` Kirti Wankhede
2019-03-25 19:49 ` Alex Williamson
2019-03-25 21:27 ` Parav Pandit
2019-03-22 23:20 ` [PATCH 5/8] vfio/mdev: Avoid masking error code to EBUSY Parav Pandit
2019-03-25 11:57 ` Maxim Levitsky
2019-03-25 19:18 ` Kirti Wankhede
2019-03-25 21:29 ` Parav Pandit
2019-03-22 23:20 ` Parav Pandit [this message]
2019-03-25 11:58 ` [PATCH 6/8] vfio/mdev: Follow correct remove sequence Maxim Levitsky
2019-03-25 20:20 ` Alex Williamson
2019-03-25 21:31 ` Parav Pandit
2019-03-22 23:20 ` [PATCH 7/8] vfio/mdev: Fix aborting mdev child device removal if one fails Parav Pandit
2019-03-25 11:58 ` Maxim Levitsky
2019-03-25 19:35 ` Kirti Wankhede
2019-03-25 20:49 ` Alex Williamson
2019-03-25 21:36 ` Parav Pandit
2019-03-25 21:52 ` Alex Williamson
2019-03-25 22:07 ` Parav Pandit
2019-03-22 23:20 ` [PATCH 8/8] vfio/mdev: Improve the create/remove sequence Parav Pandit
2019-03-25 13:24 ` Maxim Levitsky
2019-03-25 21:42 ` Parav Pandit
2019-03-25 23:18 ` Alex Williamson
2019-03-25 23:34 ` Parav Pandit
2019-03-26 0:05 ` Alex Williamson
2019-03-26 1:43 ` Parav Pandit
2019-03-26 2:16 ` Alex Williamson
2019-03-26 3:19 ` Parav Pandit
2019-03-26 5:53 ` Parav Pandit
2019-03-26 15:21 ` Alex Williamson
2019-03-26 7:06 ` Kirti Wankhede
2019-03-26 15:26 ` Alex Williamson
2019-03-27 3:19 ` Parav Pandit
2019-03-26 15:30 ` Parav Pandit
2019-03-28 17:20 ` Kirti Wankhede
2019-03-29 14:49 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553296835-37522-7-git-send-email-parav@mellanox.com \
--to=parav@mellanox.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®