From: Vitaly Mayatskikh <v.mayatskih@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Michal Hocko <mhocko@suse.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] vhost: zero vhost_vsock memory on allocation
Date: Tue, 26 Mar 2019 20:56:14 -0400 [thread overview]
Message-ID: <1553648174-24913-1-git-send-email-v.mayatskih@gmail.com> (raw)
This fixes OOPS when using under-initialized vhost_vsock object.
The code had a combo of kzalloc plus vmalloc as a fallback
initially, but it has been replaced by plain kvmalloc in
commit 6c5ab6511f71 ("mm: support __GFP_REPEAT in kvmalloc_node for >32kB")
OOPS is easy to reproduce with open/ioctl after trashing the RAM.
Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
---
drivers/vhost/vsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c
index bb5fc0e..9e7cb13 100644
--- a/drivers/vhost/vsock.c
+++ b/drivers/vhost/vsock.c
@@ -512,7 +512,7 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file)
/* This struct is large and allocation could fail, fall back to vmalloc
* if there is no other way.
*/
- vsock = kvmalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
+ vsock = kvzalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL);
if (!vsock)
return -ENOMEM;
--
1.8.3.1
next reply other threads:[~2019-03-27 0:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 0:56 Vitaly Mayatskikh [this message]
2019-03-27 8:47 ` Michal Hocko
2019-03-27 16:49 ` Stefan Hajnoczi
2019-03-27 17:08 ` Vitaly Mayatskih
2019-03-28 16:36 ` Stefan Hajnoczi
2019-03-28 17:08 ` Vitaly Mayatskih
2019-03-28 17:10 ` [PATCH] vhost/vsock: initialize vhost_vsock->hash Vitaly Mayatskikh
2019-04-05 10:24 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553648174-24913-1-git-send-email-v.mayatskih@gmail.com \
--to=v.mayatskih@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®