From: Paul Cercueil <paul@crapouillou.net>
To: Bin Liu <b-liu@ti.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me
Subject: Re: [PATCH] usb: musb: Force-disable pullup on shutdown
Date: Mon, 01 Apr 2019 19:46:22 +0200 [thread overview]
Message-ID: <1554140782.10471.0@crapouillou.net> (raw)
In-Reply-To: <20190401171725.GK25852@uda0271908>
Le lun. 1 avril 2019 à 19:17, Bin Liu <b-liu@ti.com> a écrit :
> On Thu, Mar 21, 2019 at 03:42:46PM +0100, Paul Cercueil wrote:
>> When the musb is shutdown, for instance when the driver is unloaded,
>> force-disable the pullup. Otherwise, the host will still see the
>> gadget
>> device even after the shutdown.
>
> how would this happen?
>
> when musb-hdrc driver is unloaded, udc core removes the bound gadget
> driver which calls musb_gadget_pullup() to disable the pullup.
I'm testing with the jz4740-musb driver. I don't unload the module (it's
built-in) but unbind it from sysfs.
> Regards,
> -Bin.
next prev parent reply other threads:[~2019-04-01 17:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 14:42 Paul Cercueil
2019-04-01 17:17 ` Bin Liu
2019-04-01 17:46 ` Paul Cercueil [this message]
2019-04-01 18:20 ` Bin Liu
2019-04-02 19:58 ` Paul Cercueil
2019-04-03 13:26 ` Bin Liu
2019-04-03 15:31 ` Paul Cercueil
2019-04-03 15:46 ` Bin Liu
2019-04-03 15:52 ` Paul Cercueil
2019-04-03 18:54 ` Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554140782.10471.0@crapouillou.net \
--to=paul@crapouillou.net \
--cc=b-liu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=od@zcrc.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®