From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760020AbbKTMNA (ORCPT ); Fri, 20 Nov 2015 07:13:00 -0500 Received: from mout.kundenserver.de ([217.72.192.75]:57679 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751329AbbKTMM6 (ORCPT ); Fri, 20 Nov 2015 07:12:58 -0500 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Mark Brown , Peter Zijlstra , Sascha Hauer , Liam Girdwood , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH, once again] regulator: core: avoid unused variable warning Date: Fri, 20 Nov 2015 13:12 +0100 Message-ID: <15541673.tdJ35xzzlG@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151120114127.GS31303@sirena.org.uk> References: <4219157.sstthfjICN@wuerfel> <20151120114127.GS31303@sirena.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:CkTrH0BLflUrOFz3CgCPt55p5vSE1EaqQ2vA1XYXcCtLg+CGMhX 0VRLSalE6DSoKZIouizX6EorFLNYZDXnPmyGoNrgKnqOu3LTN8afcQ0KnGftWLHByAYdj4k 7VHb6rIMZYL1ws//df/LhjqNaavD0x+vGrXnBMR97UebqyHBVscP8/63dAjscw4eGpCME1X Qsct4zLzE0Fgnee3T0ycg== X-UI-Out-Filterresults: notjunk:1;V01:K0:zVcnM8N9dOM=:YqHDBN1eNTKNSYU+KvSNRH 8oMpPXZg+sbkM072L8rq5S2uD1puRsaxWO2H5qTjgxSsb+fsVw3mkOYhejQ02VoxYgOvAbMyV GbSxU6BxNLdFAkAAxiX7IPp4CbcXuTTLWL5V7+spFYeyQ8padtBCD12zhHY5+uzcDs+UAMkt3 Gw81c/IgJGLwgTMyMd4kvWgrVamRIpQAGI5WWVSB5m5IXSEdgJzuTfk9t0gZvUuebVY4lScUf YJzPvT4cD2eP1dnugYGdwpOf2mM0ttkKgFd7Vct7HEDc1Pn7SKarYflFQlHIhsmTxEt5ZxjzG gHHTfPCjBMMS1gQr/8KOtlze821MPSgwfP6mI69PGnLgyKoLEg7F4vjjg3ipEdixAxgcIVzwA cjnLhi45mfFjMQRN639f+Mzkzfrh25Tabe+yGKWkokJ4cqXoe+XC177BR0MAU0JzsMayEq+D7 TfhYsg8oZatP2eyeRdtA3Me7wSc+dSGEhS/G8Mbr5+PFvviVazLdr1wCUgSMW9SAvaW/d3c2u t94fQL0burt5nSK4tTvW6gcc1so9qb+7azJ3EczG7yoUp2wzEBov2tjXsd57Zf7xSSrLCAekf zb9xSY8X10m9kFFPyH8CePci30JnICVe2E3sII46Hd1S0qwCOwFfGPa0T7IrfwRSiMATtA051 ldiTvtkHzM1UI8+hnHvtW5+mCjpzfCPUxWoVfaS+8GmaEy384eKHMZBxtV3sN83YQczHkvOst ktSCZo7JLTjjfz7z Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 20 November 2015 11:41:27 Mark Brown wrote: > On Fri, Nov 20, 2015 at 12:30:24PM +0100, Arnd Bergmann wrote: > > > The patch that introduced the warning is now in 4.4-rc1, and I think this > > patch is still the least ugly workaround we found. > > Can we please at least have a comment explaining that this is working > around lockdep limitations? Not sure which limitation you are referring to. Maybe you could just modify the changelog text as you like when applying the patch? The limitation we talked about in the previous thread was about the maximum of 8 nesting levels, but my patch here doesn't address that at all. I tried to capture the fact that mutex_lock_nested() intentionally doesn't evaluate its second argument when CONFIG_DEBUG_LOCK_ALLOC is not set, but that appears to be less of a limitation than a choice of the interface. Arnd