From: Paul Mackerras <paulus@au1.ibm.com>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Tom Rini <trini@kernel.crashing.org>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remove compiler.h from mmap.c
Date: Fri, 12 Apr 2002 14:52:28 +1000 (EST) [thread overview]
Message-ID: <15542.26636.857088.97277@argo.ozlabs.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.44L.0204111457100.31387-100000@duckman.distro.conectiva>
Rik van Riel writes:
> Absolutely agreed, but likely/unlikely is such low-level
> stuff that it shouldn't be included directly into .c files,
> IMHO.
mm/mmap.c uses unlikely (line 570). Therefore it should include
compiler.h itself IMHO, not rely on some other header to include it.
I think that each .c and .h file should include the headers that
define the things it uses, but should not have to include headers just
to define things that subsequent headers use.
Regards,
Paul.
prev parent reply other threads:[~2002-04-12 4:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-11 17:37 Rik van Riel
2002-04-11 17:51 ` Tom Rini
2002-04-11 17:58 ` Rik van Riel
2002-04-12 4:52 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15542.26636.857088.97277@argo.ozlabs.ibm.com \
--to=paulus@au1.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=paulus@samba.org \
--cc=riel@conectiva.com.br \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®