From: Mikael Pettersson <mikpe@csd.uu.se>
To: Pavel Roskin <proski@gnu.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Cannot compile 2.4.19-pre7 with APIC without IOAPIC
Date: Wed, 17 Apr 2002 12:37:01 +0200 [thread overview]
Message-ID: <15549.20558.197268.638473@kim.it.uu.se> (raw)
In-Reply-To: <Pine.LNX.4.44.0204162016010.2155-100000@marabou.research.att.com>
Pavel Roskin writes:
> Hello!
>
> I'm getting this error when compiling 2.4.19-pre7:
>
> init/main.o: In function `smp_init':
> init/main.o(.text.init+0x5e1): undefined reference to `skip_ioapic_setup'
> arch/i386/kernel/kernel.o: In function `broken_pirq':
> arch/i386/kernel/kernel.o(.text.init+0x3427): undefined reference to
> `skip_ioapic_setup'
>
> Processor is AMD K7, SMP is disabled, APIC is enabled, IOAPIC is disabled.
>
> It turns out that skip_ioapic_setup is defined in
> arch/i386/kernel/io_apic.c, which is only compiled when CONFIG_X86_IO_APIC
> is defined, but it's used in init/main.c if SMP is disabled and APIC is
> enabled.
Known problem. Apply the patch below.
/Mikael
--- linux-2.4.19-pre7/arch/i386/kernel/dmi_scan.c.~1~ Tue Apr 16 23:33:53 2002
+++ linux-2.4.19-pre7/arch/i386/kernel/dmi_scan.c Tue Apr 16 23:34:15 2002
@@ -362,7 +362,7 @@
printk(KERN_INFO " *** If you see IRQ problems, in paticular SCSI resets and hangs at boot\n");
printk(KERN_INFO " *** contact your hardware vendor and ask about updates.\n");
printk(KERN_INFO " *** Building an SMP kernel may evade the bug some of the time.\n");
-#ifdef CONFIG_X86_UP_APIC
+#ifdef CONFIG_X86_IO_APIC
skip_ioapic_setup = 0;
#endif
return 0;
--- linux-2.4.19-pre7/init/main.c.~1~ Tue Apr 16 23:33:56 2002
+++ linux-2.4.19-pre7/init/main.c Tue Apr 16 23:34:54 2002
@@ -293,11 +293,9 @@
#ifndef CONFIG_SMP
#ifdef CONFIG_X86_LOCAL_APIC
-extern int skip_ioapic_setup;
static void __init smp_init(void)
{
- if (!skip_ioapic_setup)
- APIC_init_uniprocessor();
+ APIC_init_uniprocessor();
}
#else
#define smp_init() do { } while (0)
prev parent reply other threads:[~2002-04-17 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-17 0:27 Pavel Roskin
2002-04-17 10:37 ` Mikael Pettersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15549.20558.197268.638473@kim.it.uu.se \
--to=mikpe@csd.uu.se \
--cc=linux-kernel@vger.kernel.org \
--cc=proski@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®