From: Wen Yang <wen.yang99@zte.com.cn>
To: linux-kernel@vger.kernel.org
Cc: wang.yi59@zte.com.cn, Wen Yang <wen.yang99@zte.com.cn>,
Linus Walleij <linus.walleij@linaro.org>,
linux-gpio@vger.kernel.org
Subject: [PATCH 1/5] pinctrl: pistachio: fix leaked of_node references
Date: Fri, 12 Apr 2019 14:02:19 +0800 [thread overview]
Message-ID: <1555048943-39589-2-git-send-email-wen.yang99@zte.com.cn> (raw)
In-Reply-To: <1555048943-39589-1-git-send-email-wen.yang99@zte.com.cn>
The call to of_get_child_by_name returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.
Detected by coccinelle with the following warnings:
./drivers/pinctrl/pinctrl-pistachio.c:1422:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1360, but without a corresponding object release within this function.
Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/pinctrl/pinctrl-pistachio.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c
index aa5f949..5b0678f 100644
--- a/drivers/pinctrl/pinctrl-pistachio.c
+++ b/drivers/pinctrl/pinctrl-pistachio.c
@@ -1367,6 +1367,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
if (!of_find_property(child, "gpio-controller", NULL)) {
dev_err(pctl->dev,
"No gpio-controller property for bank %u\n", i);
+ of_node_put(child);
ret = -ENODEV;
goto err;
}
@@ -1374,6 +1375,7 @@ static int pistachio_gpio_register(struct pistachio_pinctrl *pctl)
irq = irq_of_parse_and_map(child, 0);
if (irq < 0) {
dev_err(pctl->dev, "No IRQ for bank %u: %d\n", i, irq);
+ of_node_put(child);
ret = irq;
goto err;
}
--
2.9.5
next prev parent reply other threads:[~2019-04-12 6:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 6:02 [PATCH 0/5] fix leaked of_node references in drivers/pinctrl Wen Yang
2019-04-12 6:02 ` Wen Yang [this message]
2019-04-14 13:15 ` [PATCH 1/5] pinctrl: pistachio: fix leaked of_node references Markus Elfring
2019-04-23 10:34 ` Linus Walleij
2019-04-12 6:02 ` [PATCH 2/5] pinctrl: rockchip: " Wen Yang
2019-04-12 8:08 ` Heiko Stübner
2019-04-12 6:02 ` [PATCH 3/5] pinctrl: st: " Wen Yang
2019-04-12 8:57 ` Patrice CHOTARD
2019-04-23 9:02 ` Linus Walleij
2019-04-12 6:02 ` [PATCH 4/5] pinctrl: samsung: " Wen Yang
2019-04-12 7:12 ` Krzysztof Kozlowski
2019-04-23 9:00 ` Linus Walleij
2019-04-12 6:02 ` [PATCH 5/5] pinctrl: zte: " Wen Yang
2019-04-16 5:56 ` Shawn Guo
2019-04-23 10:53 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555048943-39589-2-git-send-email-wen.yang99@zte.com.cn \
--to=wen.yang99@zte.com.cn \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wang.yi59@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®