From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, srivatsa.bhat@linux.vnet.ibm.com,
nicolas.pitre@linaro.org
Subject: Re: [PATCH 0/4] CPUFreq stats: Bug fixes
Date: Mon, 06 Jan 2014 22:02:35 +0100 [thread overview]
Message-ID: <1555125.bAi9TgavWd@vostro.rjw.lan> (raw)
In-Reply-To: <cover.1380190886.git.viresh.kumar@linaro.org>
On Thursday, September 26, 2013 03:59:50 PM Viresh Kumar wrote:
> Hi Rafael,
>
> I know you asked me not to send any more patches before the earlier ones get
> into kernel. I got to this as Nicolas Pitre required to send few CPUFreq patches
> for ARM's big LITTLE In-Kernel-Switcher. And within linaro we have hacked these
> bugs in a bad way..
>
> Because of his dependency I am forced to send these.. These aren't introduced
> recently and so they can be included in 3.13.
>
> There are several problems/bugs in cpufreq-stats specially with cpufreq drivers
> as modules and suspend/resume path. These are mentioned well in changelogs.
>
> These are tested over my thinkpad (acpi-cpufreq) in following way:
> [1] offline+online all CPUs except boot cpu in a while loop
> [2] then do suspend resume
> [3] repeat [1] and [2] several times.
>
> No issues found..
>
> Also tested on my exynos board:
> - Added cpufreq_unregister/register while loop in exynos-cpufreq.c so that we
> continuously register/unregister driver... Stats were working fine now..
> - Compile cpufreq-stats as module and insert/remove it several times after
> removing above hack (as that doesn't let linux boot :) )..
>
> @Srivatsa: You also have fairly good idea of cpufreq now, so please give some
> time to review this :)
>
> @Nico: Can you remove the hacky code from IKS tree and test these instead to see
> if we still have any issues?
Can you please rebase this series on top of linux-pm.git/bleeding-edge and
resend it? Chances are it might make it into 3.14.
Thanks,
Rafael
prev parent reply other threads:[~2014-01-06 20:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 10:29 Viresh Kumar
2013-09-26 10:29 ` [PATCH 1/4] cpufreq: stats: handle cpufreq_unregister_driver() and suspend/resume properly Viresh Kumar
2013-09-26 10:29 ` [PATCH 2/4] cpufreq: stats: remove hotplug notifiers Viresh Kumar
2013-09-26 10:29 ` [PATCH 3/4] cpufreq: stats: free table and remove sysfs entry in a single routine Viresh Kumar
2013-09-26 10:29 ` [PATCH 4/4] cpufreq: stats: create sysfs entries when cpufreq_stats is a module Viresh Kumar
2013-10-22 21:06 ` [PATCH 0/4] CPUFreq stats: Bug fixes Nicolas Pitre
2013-10-23 4:23 ` Viresh Kumar
2014-01-06 21:02 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555125.bAi9TgavWd@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=patches@linaro.org \
--cc=rjw@sisk.pl \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®