From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753548AbbJOPgE (ORCPT ); Thu, 15 Oct 2015 11:36:04 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:54401 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753309AbbJOPgB (ORCPT ); Thu, 15 Oct 2015 11:36:01 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Tejun Heo , Tang Yuantian , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, hdegoede@redhat.com, fengguang.wu@intel.com Subject: Re: [PATCH] ahci: qoriq: Fix a compiling warning Date: Thu, 15 Oct 2015 17:35:20 +0200 Message-ID: <15555694.OtW6JZzsoS@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <20151015151152.GB27717@mtj.duckdns.org> References: <1444812412-33321-1-git-send-email-Yuantian.Tang@freescale.com> <20151015151152.GB27717@mtj.duckdns.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:K49zSpaHxj6Z1hRYzR7bMIamM7bD5M6ldEk0oIpGfZpcz3ByAWC PmLQ5GfHTm6+6ERlEejQkVMXv3CHPazWcMxSedzmTfgsPs0j1MD+tYE3GoQ7yltWHWrIK4a HJhZ8jpHxD0/a1nkYM2qI40Z0FNFc2qTrrCavAnaqAGlyYCtSzUe1CTHRqdHtktP6rz0KqZ 54zlQ4Dsgbm8EOUkOfILg== X-UI-Out-Filterresults: notjunk:1;V01:K0:Sp547h4ZYvI=:HdTNNFHVEw8bkPGok8P+g4 mYchRKA9vhSDjIAHOd0+hqDL+c2xz97vRbDfQF2EzKgs2tGasB2Kw06WtnmvhtnzUkulq27mR qFEmPsxWvoJQlO2sxfN0v0EB+l9T9M8tf51xXU62s2feD8Z2bTYuV3slFV7FmVE6jKcTGz3ju jdNYm7gvP6bF0a5FDykWWKtXoLy/0N4AntiV8wA0tgJVUMqKmMBgCdLFDeCkoHiEQXJ6jXvfM MfSvF5tAVm+tMO7yhUJqlkjSXZvV4b7S5T7cc6xEBzsiHbdoZy3IA2DQLuhYxPZY3xj3vbyyv aouQ8KnsEZNOrwuOQYc7WZuTL/cCIEnVDbHLQiwmbHi9fSHJ7hBghyBq+MiFbzNUOX/lA/QXR kM7WWkCK4dX3v6tTWYYvPkAexoG+HdBcHUAIpAm+Vfrs7KcKfnR4hpSQZ2wdgdX8b8UMPP5Jz O5g+BCB1G+FB6Zb5BWJ9wzBpjRdfPhk5zmhod3/9K0TrxND/y9LA8V1xlqrucEI7IAFIvla2D AYmdpFP1DjXswRa6MvOdyNj0lLVehOvGR0EDjuJoixiFoHZ7PJni/0URApvi8HX0fme1zdk0g A0HcNdrdQcV02Bqxb1ovMUsK0HZsEyrC5ts2V8a8jNE9O8LZWQzVDEQnhq8GsDf8o14yuEdbZ 8nayZ5pqRJK7Vfc4B0b3jPOMRvYqAxk51sIXUo9WcKxqehgadREhtt0t+wmHkwpe8I54b/Ms5 bfgDQOxRZZPtRngF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 15 October 2015 11:11:52 Tejun Heo wrote: > > On Wed, Oct 14, 2015 at 04:46:52PM +0800, Tang Yuantian wrote: > > kbuild test robot reports the warnings: > > drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': > > >> include/asm-generic/io.h:163:2: warning: 'px_is' may be used > > >> uninitialized in this function [-Wuninitialized] > > drivers/ata/ahci_qoriq.c:70:14: note: 'px_is' was declared here > > >> include/asm-generic/io.h:163:2: warning: 'px_cmd' may be used > > >> uninitialized in this function [-Wuninitialized] > > drivers/ata/ahci_qoriq.c:70:6: note: 'px_cmd' was declared here > > > > This patch fixed it by introducing a local variable. > > > > Signed-off-by: Arnd Bergmann > > Hmmm... why is the patch signed off by Arnd? You can't sign off for > other people. If this was suggested by Arnd, please use > "Suggested-by:" or "Original-patch-by:". The original patch I sent had my Signed-off-by, see https://lkml.org/lkml/2015/9/14/64 Tang Yuantian now submitted it properly with a full changelog text but forgot to add the 'From: Arnd Bergmann ' line at the start and the second Signed-off-by below mine. Arnd