From: Oliver Neukum <oneukum@suse.de>
To: Yann Cantin <yann.cantin@laposte.net>
Cc: linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
gregkh@linuxfoundation.org, dmitry.torokhov@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver.
Date: Fri, 24 Aug 2012 13:41:04 +0200 [thread overview]
Message-ID: <1555763.Oi7gGGn7BU@linux-lqwf.site> (raw)
In-Reply-To: <50374B69.3040002@laposte.net>
On Friday 24 August 2012 11:37:45 Yann Cantin wrote:
> Hi,
>
> Le 23/08/2012 09:23, Oliver Neukum a écrit :
> > On Thursday 23 August 2012 00:11:54 Yann Cantin wrote:
> > These functions are identical. You should unify them.
>
> Removed reset_resume from the driver (optional, and not needed
> for this hardware).
Why did you do that? It is always better to have reset_resume().
And you cannot tell whether it will be needed.
Regards
Oliver
next prev parent reply other threads:[~2012-08-24 11:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 22:11 [RFC ebeam PATCH v4 0/2] new " Yann Cantin
2012-08-22 22:11 ` [RFC ebeam PATCH v4 1/2] hid: Blacklist eBeam devices Yann Cantin
2012-08-22 22:11 ` [RFC ebeam PATCH v4 2/2] input: misc: New USB eBeam input driver Yann Cantin
2012-08-23 6:54 ` Oliver Neukum
2012-08-24 9:31 ` Yann Cantin
2012-08-23 7:23 ` Oliver Neukum
2012-08-24 9:37 ` Yann Cantin
2012-08-24 11:41 ` Oliver Neukum [this message]
2012-08-24 14:42 ` Yann Cantin
2012-09-03 12:59 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555763.Oi7gGGn7BU@linux-lqwf.site \
--to=oneukum@suse.de \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=yann.cantin@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®