From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751424AbdHFIRJ (ORCPT ); Sun, 6 Aug 2017 04:17:09 -0400 Received: from mout.web.de ([212.227.17.11]:55886 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbdHFIRH (ORCPT ); Sun, 6 Aug 2017 04:17:07 -0400 To: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, Chas Williams <3chas3@gmail.com> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] ATM-nicstar: Delete an error message for a failed memory allocation in ns_init_card() Message-ID: <15557ccf-4b14-924a-b1ce-8fa052f0e1f0@users.sourceforge.net> Date: Sun, 6 Aug 2017 10:16:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:p2JCNnfQH3EcoQKsWxt8dMKZv8dgsqIV+ssE6+vCcEtZXhCdjq1 9zaJWGrJbcii0xvOPgOlIwAs5BTEes5L2xySKL/UahTRjJXjFPsAUrePuBoBYxlSakRYKI3 5XK+o2rbzI1Vnl1jwLuj8zFjoqNQtSHMgWmXQ7uBS8xJpP1U9LcgG5ELDDL2JbWf6wzUOWb UUkeV7AACajp2CApzULmQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/KipNtACGpk=:Dlq5II+dmXaS2UqLjO/Xyw 0kJGCJVyaqggdNzuSBUqOczcvp+F2SrQ9GFJ0UCXFrweU5r9nkcinx8OITrjIuwHVNQqb8//q RhHQyJSqL/T6Vk+byn1hHlSja7meYegxB89hPSRCN5gbOTPJ6sb0IsMQ7IIsJ92tjsWzaLMtl 8Xltr9wony4VXzWH7VaRSp7JILH9NKYEC8PMkV4EdpMwiHfuoECelbf07vX1/8rzFAMb4eoge IMIg5+ovYA94e+9x0dAshYC46fJc4Ut04XPgSvlSNLbloHLg8eXZaQ2cS86Tso+z4LhiTobwa kL2aY4R1clQwP/MugAxcn619dSBQ3MHyevzI+p+XOzZcb83ZRUWW8G5xe6Y2MRiW01ZS0y4u9 kKVBh/bxuInwCh6zxH5yOGWvZKezXW72njEwWQywmWns/Yiny0KNkPezid8m1kwUt711u0ADT FPaLnJi669psPaEwvlTj16zepXGcz/xEqu5UHpQ4mSVi1kxV254JKvuHybiK9PhwoiN45/wWq z9aNlVv/hurw53l4eygwgZX61cfziItIaHDC0sChtaIvMko8KquvjhNkrlCSFsY0RhRD2Uxqa mDHXfCNPK29xUYCCcL+FL1Ke+pNazOR+xOk0awJjBpvcdzkUzHLCqNHDbfdcoe9NJA34n0XkD Ra7IE4UeebHaYsMxxmhpRxOh6yK29baj6PdKURBa7G5DlS6wWpsguZ+NdizuyfAkAF9PI0Y79 ofbLREwUEUl5rmRkg5PzMlhr/IwkcuzP483qUIcvDCuIh2/mLYr73D6vqeePfScrrsAR4nRkJ wbvPNC7aZyv+LFdmEqMdEMW3lntQO8fPRHw2E1antXfPFjEjv4= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 6 Aug 2017 10:10:21 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/atm/nicstar.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c index 9588d80f318e..08d5aa8b9524 100644 --- a/drivers/atm/nicstar.c +++ b/drivers/atm/nicstar.c @@ -372,9 +372,6 @@ static int ns_init_card(int i, struct pci_dev *pcidev) card = kmalloc(sizeof(*card), GFP_KERNEL); if (!card) { - printk - ("nicstar%d: can't allocate memory for device structure.\n", - i); error = 2; ns_init_card_error(card, error); return error; -- 2.13.4