From: NeilBrown <neil@brown.name>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
thirtythreeforty@gmail.com
Subject: [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type
Date: Sat, 04 May 2019 20:24:56 +1000 [thread overview]
Message-ID: <155696549653.8632.3279283591868841381.stgit@noble.brown> (raw)
In-Reply-To: <155696540998.8632.5242582397805128125.stgit@noble.brown>
When using devicetree for configuration, interrupt trigger type
should be described in the dts file, not hard-coded in the C code.
The mtk-sd silicon in the mt7621 soc uses an active-high interrupt
and so cannot be used with the current code.
So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE.
Also IRQF_ONESHOT is not needed - it is used for threaded interrupt
handlers, and this driver does not used a threaded interrupt handler.
So remove that setting.
Signed-off-by: NeilBrown <neil@brown.name>
---
drivers/mmc/host/mtk-sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
index 0798f0ba6d34..469d4a717175 100644
--- a/drivers/mmc/host/mtk-sd.c
+++ b/drivers/mmc/host/mtk-sd.c
@@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev)
msdc_init_hw(host);
ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq,
- IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host);
+ IRQF_TRIGGER_NONE, pdev->name, host);
if (ret)
goto release;
next prev parent reply other threads:[~2019-05-04 10:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 10:24 [PATCH 0/4] mtk-sd enhancement to support MT7621 - V2 NeilBrown
2019-05-04 10:24 ` NeilBrown [this message]
2019-05-05 7:43 ` [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type Chaotian Jing
2019-05-04 10:24 ` [PATCH 2/4] mmc: mtk-sd: add support for config found in mt7620 family SOCs NeilBrown
2019-05-05 7:49 ` Chaotian Jing
2019-05-04 10:24 ` [PATCH 4/4] mmc: mtk-sd: select REGULATOR NeilBrown
2019-05-05 7:52 ` Chaotian Jing
2019-05-04 10:24 ` [PATCH 3/4] mmc: mtk-sd: enable internal card-detect logic NeilBrown
2019-05-05 7:52 ` Chaotian Jing
2019-05-06 9:51 ` [PATCH 0/4] mtk-sd enhancement to support MT7621 - V2 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155696549653.8632.3279283591868841381.stgit@noble.brown \
--to=neil@brown.name \
--cc=chaotian.jing@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=thirtythreeforty@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®