From: David Mosberger <davidm@napali.hpl.hp.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: maximum block size in buffer_head
Date: Thu, 9 May 2002 23:35:16 -0700 [thread overview]
Message-ID: <15579.27172.621514.289282@napali.hpl.hp.com> (raw)
In-Reply-To: <3CDB5CC5.2621C68C@zip.com.au>
>>>>> On Thu, 09 May 2002 22:38:13 -0700, Andrew Morton <akpm@zip.com.au> said:
Andrew> Sounds OK to me for 2.5.
Will you make the change then? I'd appreciate that.
Andrew> For 2.4, a 32-bit b_size would push sizeof(buffer_head) from
Andrew> 96 up to 100 bytes, which does not pack as well into the
Andrew> slab. This would be an intensely unpopular move. So you'd
Andrew> have to ifdef it. Which makes it an ia64-only problem,
Andrew> which greatly improves your merge chances ;)
For 2.4, I suspect I need to keep this in the ia64 patch anyhow
because it is also necessary to fix scsi_dma.c so it can deal with
allocation bitmaps that are bigger than 32 bits.
I believe ia64 is currently the only platform that supports 64KB
pages. If so, there is probably not much point trying to get this
past Marcelo (and the patch is large enough to have the potential for
introducing new bugs). If another platform cares about this, please
speak up.
>> - does anyone know of any other code paths where the block size
>> is assumed to fit into 16 bits?
Andrew> Not off the top, but they're probably there.
I'll keep an eye on it. It's working fine so far, but that doesn't
replace a code audit. If you happen to bump into something during
your normal work, please let me know.
Thanks,
--david
prev parent reply other threads:[~2002-05-10 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-10 5:11 David Mosberger
2002-05-10 5:38 ` Andrew Morton
2002-05-10 6:35 ` David Mosberger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15579.27172.621514.289282@napali.hpl.hp.com \
--to=davidm@napali.hpl.hp.com \
--cc=akpm@zip.com.au \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®