From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0675CC04AB6 for ; Tue, 28 May 2019 12:52:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB94420883 for ; Tue, 28 May 2019 12:52:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbfE1MwC (ORCPT ); Tue, 28 May 2019 08:52:02 -0400 Received: from metis.ext.pengutronix.de ([85.220.165.71]:58045 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726924AbfE1MwB (ORCPT ); Tue, 28 May 2019 08:52:01 -0400 Received: from kresse.hi.pengutronix.de ([2001:67c:670:100:1d::2a]) by metis.ext.pengutronix.de with esmtp (Exim 4.89) (envelope-from ) id 1hVbZz-0003P1-Qv; Tue, 28 May 2019 14:51:47 +0200 Message-ID: <1559047905.4039.15.camel@pengutronix.de> Subject: Re: [PATCH] arm64: dts: fsl: imx8mq: enable the svns power key From: Lucas Stach To: "Angus Ainslie (Purism)" , angus.ainslie@puri.sm Cc: Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Abel Vesa , Andrey Smirnov , Carlo Caione , Guido =?ISO-8859-1?Q?G=FCnther?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 28 May 2019 14:51:45 +0200 In-Reply-To: <20190528124406.29730-1-angus@akkea.ca> References: <20190528124406.29730-1-angus@akkea.ca> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::2a X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Angus, Am Dienstag, den 28.05.2019, 05:44 -0700 schrieb Angus Ainslie (Purism): > Add the snvs power key. > > > Signed-off-by: Angus Ainslie (Purism) > --- >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 9 +++++++++ >  1 file changed, 9 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 45d10d8efd14..5f93fd9662ae 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -8,6 +8,7 @@ >  #include >  #include >  #include > +#include "dt-bindings/input/input.h" >  #include >  #include >  #include "imx8mq-pinfunc.h" > @@ -463,6 +464,14 @@ > >   interrupts = , > >   ; > >   }; > + > > + snvs_pwrkey: snvs-powerkey { > > + compatible = "fsl,sec-v4.0-pwrkey"; > > + regmap = <&snvs>; > > + interrupts = ; > > + linux,keycode = ; > + wakeup-source; Not all i.MX8MQ systems will have this functionality wired up at the board level, so this node needs to be disabled by default. The existing i.MX6 and i.MX7 DTs seem to get this wrong. Regards, Lucas > + }; > >   }; >   > > >   clk: clock-controller@30380000 {