From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 294CCC28CC0 for ; Thu, 30 May 2019 02:13:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 051C424426 for ; Thu, 30 May 2019 02:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727407AbfE3CNl (ORCPT ); Wed, 29 May 2019 22:13:41 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:24730 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726454AbfE3CNk (ORCPT ); Wed, 29 May 2019 22:13:40 -0400 X-UUID: 86029ab1131847df8fbb925b3fe479c1-20190530 X-UUID: 86029ab1131847df8fbb925b3fe479c1-20190530 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 881203175; Thu, 30 May 2019 10:13:36 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 10:13:35 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 May 2019 10:13:35 +0800 Message-ID: <1559182415.6868.0.camel@mtksdaap41> Subject: Re: [PATCH v2 1/4] drm: mediatek: fix unbind functions From: CK Hu To: Hsin-Yi Wang CC: , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , , , Date: Thu, 30 May 2019 10:13:35 +0800 In-Reply-To: <20190529102555.251579-2-hsinyi@chromium.org> References: <20190529102555.251579-1-hsinyi@chromium.org> <20190529102555.251579-2-hsinyi@chromium.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-Yi: On Wed, 2019-05-29 at 18:25 +0800, Hsin-Yi Wang wrote: > detatch panel in mtk_dsi_destroy_conn_enc(), since .bind will try to > attach it again. > Reviewed-by: CK Hu > Fixes: 2e54c14e310f ("drm/mediatek: Add DSI sub driver") > Signed-off-by: Hsin-Yi Wang > --- > change log v1->v2: > * mipi_dsi_host_unregister() should be fixed in another patch on the list. > --- > drivers/gpu/drm/mediatek/mtk_dsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c > index b00eb2d2e086..1ae3be99e0ff 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -844,6 +844,8 @@ static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi) > /* Skip connector cleanup if creation was delegated to the bridge */ > if (dsi->conn.dev) > drm_connector_cleanup(&dsi->conn); > + if (dsi->panel) > + drm_panel_detach(dsi->panel); > } > > static void mtk_dsi_ddp_start(struct mtk_ddp_comp *comp)