From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC862C072B1 for ; Thu, 30 May 2019 07:10:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC7D5249CD for ; Thu, 30 May 2019 07:10:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727505AbfE3HKe (ORCPT ); Thu, 30 May 2019 03:10:34 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:9799 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726100AbfE3HKd (ORCPT ); Thu, 30 May 2019 03:10:33 -0400 X-UUID: 4e95dbfb47c6469ab5ffd272f063cf7b-20190530 X-UUID: 4e95dbfb47c6469ab5ffd272f063cf7b-20190530 Received: from mtkmrs01.mediatek.inc [(172.21.131.159)] by mailgw02.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1579835748; Thu, 30 May 2019 15:10:29 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs01n2.mediatek.inc (172.21.101.79) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 30 May 2019 15:10:26 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 30 May 2019 15:10:26 +0800 Message-ID: <1559200226.23119.4.camel@mtksdaap41> Subject: Re: [PATCH v3] gpu/drm: mediatek: call mtk_dsi_stop() after mtk_drm_crtc_atomic_disable() From: CK Hu To: Hsin-Yi Wang CC: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Philipp Zabel , David Airlie , lkml , , "Matthias Brugger" , , Daniel Vetter Date: Thu, 30 May 2019 15:10:26 +0800 In-Reply-To: References: <20190528073908.633-1-hsinyi@chromium.org> <1559033586.5141.3.camel@mtksdaap41> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-SNTS-SMTP: 21091E5AA1B68CD54EA112FEDEABEE38DDE2401439AE716AE08C1FA05B4F42452000:8 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Hsin-Yi: On Thu, 2019-05-30 at 10:55 +0800, Hsin-Yi Wang wrote: > On Tue, May 28, 2019 at 4:53 PM CK Hu wrote: > > > I think we've already discussed in [1]. I need a reason to understand > > this is hardware behavior or software bug. If this is a software bug, we > > need to fix the bug and code could be symmetric. > > > > [1] > > http://lists.infradead.org/pipermail/linux-mediatek/2019-March/018423.html > > > Hi CK, > > Jitao has replied in v2[1] > " > mtk_dsi_start must after dsi full setting. > If you put it in mtk_dsi_ddp_start, mtk_dsi_set_mode won't work. DSI > will keep cmd mode. So you see no irq. > ... > " > > [1] https://lore.kernel.org/patchwork/patch/1052505/#1276270 > > Thanks OK, this looks the hardware behavior, so I would like you to add comment in the code to describe why we need this asymmetric behavior. The description should be clear so that we could know how to modify the code flow in future. Regards, CK