From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F635C04AB6 for ; Fri, 31 May 2019 03:40:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C7312632C for ; Fri, 31 May 2019 03:40:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbfEaDks (ORCPT ); Thu, 30 May 2019 23:40:48 -0400 Received: from mailgw02.mediatek.com ([1.203.163.81]:62049 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726531AbfEaDks (ORCPT ); Thu, 30 May 2019 23:40:48 -0400 X-UUID: 90c434ee22d747c5a374ad6b8076e0ab-20190531 X-UUID: 90c434ee22d747c5a374ad6b8076e0ab-20190531 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw02.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 1162707599; Fri, 31 May 2019 11:40:43 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by MTKMBS33N2.mediatek.inc (172.27.4.76) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 31 May 2019 11:40:41 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Fri, 31 May 2019 11:40:41 +0800 Message-ID: <1559274041.9102.3.camel@mtksdaap41> Subject: Re: [v3 7/7] drm: mediatek: adjust dsi and mipi_tx probe sequence From: CK Hu To: Jitao Shi CC: Rob Herring , Pawel Moll , "Mark Rutland" , Ian Campbell , Kumar Gala , , David Airlie , "Matthias Brugger" , Thierry Reding , "Ajay Kumar" , Inki Dae , "Rahul Sharma" , Sean Paul , Vincent Palatin , Andy Yan , Philipp Zabel , "Russell King" , , , , , , , Sascha Hauer , , , , , Date: Fri, 31 May 2019 11:40:41 +0800 In-Reply-To: <20190519092537.69053-8-jitao.shi@mediatek.com> References: <20190519092537.69053-1-jitao.shi@mediatek.com> <20190519092537.69053-8-jitao.shi@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Jitao: On Sun, 2019-05-19 at 17:25 +0800, Jitao Shi wrote: > mtk_mipi_tx is the phy of mtk_dsi. > mtk_dsi get the phy(mtk_mipi_tx) in probe(). > > So, mtk_mipi_tx init should be ahead of mtk_dsi. Or mtk_dsi will > defer to wait mtk_mipi_tx probe done. Reviewed-by: CK Hu > > Signed-off-by: Jitao Shi > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index cf59ea9bccfd..583d533d9574 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -633,8 +633,8 @@ static struct platform_driver * const mtk_drm_drivers[] = { > &mtk_disp_rdma_driver, > &mtk_dpi_driver, > &mtk_drm_platform_driver, > - &mtk_dsi_driver, > &mtk_mipi_tx_driver, > + &mtk_dsi_driver, > }; > > static int __init mtk_drm_init(void)