From: "Enrico Weigelt, metux IT consult" <info@metux.net>
To: linux-kernel@vger.kernel.org
Cc: axboe@kernel.dk, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-block@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: [PATCH 2/3] drivers: block: xsysace: use MODULE_OF_TABLE() and of_match_ptr()
Date: Fri, 31 May 2019 13:54:49 +0200 [thread overview]
Message-ID: <1559303690-8108-3-git-send-email-info@metux.net> (raw)
In-Reply-To: <1559303690-8108-1-git-send-email-info@metux.net>
Using MODULE_OF_TABLE() and of_match_ptr() macros to get rid of
some #ifdef CONFIG_OF and thus make the code a bit slimmer.
These macros already check whether CONFIG_OF is set and if it's
not, just no-op. The compiler then should be able to optimize-
away unreferenced structs.
Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
---
drivers/block/xsysace.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/block/xsysace.c b/drivers/block/xsysace.c
index 464c9092..6ebd656 100644
--- a/drivers/block/xsysace.c
+++ b/drivers/block/xsysace.c
@@ -1219,7 +1219,6 @@ static int ace_remove(struct platform_device *dev)
return 0;
}
-#if defined(CONFIG_OF)
/* Match table for of_platform binding */
static const struct of_device_id ace_of_match[] = {
{ .compatible = "xlnx,opb-sysace-1.00.b", },
@@ -1228,17 +1227,14 @@ static int ace_remove(struct platform_device *dev)
{ .compatible = "xlnx,sysace", },
{},
};
-MODULE_DEVICE_TABLE(of, ace_of_match);
-#else /* CONFIG_OF */
-#define ace_of_match NULL
-#endif /* CONFIG_OF */
+MODULE_OF_TABLE(ace_of_match);
static struct platform_driver ace_platform_driver = {
.probe = ace_probe,
.remove = ace_remove,
.driver = {
.name = "xsysace",
- .of_match_table = ace_of_match,
+ .of_match_table = of_match_ptr(ace_of_match),
},
};
--
1.9.1
next prev parent reply other threads:[~2019-05-31 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-31 11:54 RFC: get rid of #ifdef CONFIG_OF's around of match tables Enrico Weigelt, metux IT consult
2019-05-31 11:54 ` [PATCH 1/3] mod_devicetable: helper macro for declaring oftree module device table Enrico Weigelt, metux IT consult
2019-05-31 11:54 ` Enrico Weigelt, metux IT consult [this message]
2019-05-31 11:54 ` [PATCH 3/3] drivers: crypto: picoxcell_crypto: use MODULE_OF_TABLE() Enrico Weigelt, metux IT consult
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559303690-8108-3-git-send-email-info@metux.net \
--to=info@metux.net \
--cc=axboe@kernel.dk \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-block@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®