From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752747AbcAXBQi (ORCPT ); Sat, 23 Jan 2016 20:16:38 -0500 Received: from v094114.home.net.pl ([79.96.170.134]:46213 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751898AbcAXBQg (ORCPT ); Sat, 23 Jan 2016 20:16:36 -0500 From: "Rafael J. Wysocki" To: Insu Yun Cc: lenb@kernel.org, bhelgaas@google.com, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu, changwoo@gatech.edu Subject: Re: [PATCH] hotplug: unlock in error path in acpiphp_enable_slot Date: Sun, 24 Jan 2016 02:17:24 +0100 Message-ID: <1559503.GJNuT7qv7A@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.4.0; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1453581859-19565-1-git-send-email-wuninsu@gmail.com> References: <1453581859-19565-1-git-send-email-wuninsu@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, January 23, 2016 03:44:19 PM Insu Yun wrote: > In acpiphp_enable_slot, there is a missing unlock path > when error occurred. It needs to be unlocked before returning an error. > > Signed-off-by: Insu Yun Applied, thanks! > --- > drivers/pci/hotplug/acpiphp_glue.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c > index ff53856..0b3e0bf 100644 > --- a/drivers/pci/hotplug/acpiphp_glue.c > +++ b/drivers/pci/hotplug/acpiphp_glue.c > @@ -953,8 +953,10 @@ int acpiphp_enable_slot(struct acpiphp_slot *slot) > { > pci_lock_rescan_remove(); > > - if (slot->flags & SLOT_IS_GOING_AWAY) > + if (slot->flags & SLOT_IS_GOING_AWAY) { > + pci_unlock_rescan_remove(); > return -ENODEV; > + } > > /* configure all functions */ > if (!(slot->flags & SLOT_ENABLED)) > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.