From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B80FC04AB5 for ; Mon, 3 Jun 2019 21:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 683E226C8F for ; Mon, 3 Jun 2019 21:42:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="pfkd4E2G" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726642AbfFCVmO (ORCPT ); Mon, 3 Jun 2019 17:42:14 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34460 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725956AbfFCVmN (ORCPT ); Mon, 3 Jun 2019 17:42:13 -0400 Received: by mail-qt1-f195.google.com with SMTP id m29so6119325qtu.1 for ; Mon, 03 Jun 2019 14:42:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=pjVCLroEtR5thtHENU+41rmsthzX90Qup8xKfLtuOIo=; b=pfkd4E2GZhwBrpTBDy41iK9bDLDvxxPtMWsvXyKKAvnL3nyFYdOlbY+4chm5yWk0Wb qXmRk96a+AKlcw9Z3ejPTjgd79mhpu7UizX6spgbdgENGWa/jwTRUHMlrToiuoAJMXND pq6xFCh5TxYutdpHSbzSbSobJ9V0XIJnU6lmOLmKAl2i3vIOozeoVogTcrvFGgTShzZU cO20V/X8ahmZtzIPNoUXp0ZcNoj+4diTVOHseIupVeJumksjKbwj/uhca/ZxUwhqL1Vp gi94VQSybvkwzPKLsP1AHd++spokzJb8dbXt1mseN7tA41hL6RREvck60u2mdwu1CfQ8 f+nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pjVCLroEtR5thtHENU+41rmsthzX90Qup8xKfLtuOIo=; b=OG/Zi7cdXfjSukJ7Lot2IJ68FzLsPmGla38gKkH7i2bwkHM9vFQkw79mFs+MdV1ZYf FMC8+djZO4AcfISN1DwJU1k4P9fZI7qmI6sTV5EzG/d3PmPHOA1C7u3r3i5yEySxIp/x BK+JpkReJX1Y7rGD25WajERoArvFUP1qF1Z1R2YXZr8qPoy1brvfNeJMWnpxVuIqWxod DGWoeG4QYjAC6G5hG/nCrs26bkvRhJ049rLva5y+VmX2wR38VmVBnzmOrJLhefPlFvYH C4V4XE/jA70tTDF8/bixJJpd6g4KhFRSu2KjMIH85/zVo5/8AJZalr5rDXdZetrE2YhP qH5A== X-Gm-Message-State: APjAAAWhW0d+W4IhUG8hIvlHafXTsdpY3voYs/ZmPiEXLQM6PmvaDhxx nBkjO5yjp+89X4JWfQezcVK91rR1Yag= X-Google-Smtp-Source: APXvYqx2IFqPZYkpCNzUaA3pYzBxSExTSI6Kjnb4xGdkz0M1DgqStPbaU54SKBENuzBxcSlvUoF7sw== X-Received: by 2002:a0c:d91b:: with SMTP id p27mr7963388qvj.236.1559596330763; Mon, 03 Jun 2019 14:12:10 -0700 (PDT) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id d25sm1245907qko.96.2019.06.03.14.12.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jun 2019 14:12:10 -0700 (PDT) From: Qian Cai To: mingo@redhat.com Cc: peterz@infradead.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH v2] sched: fix "runnable_avg_yN_inv" not used warnings Date: Mon, 3 Jun 2019 17:11:44 -0400 Message-Id: <1559596304-31581-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org runnable_avg_yN_inv[] is only used in kernel/sched/pelt.c but was included in several other places because they need other macros all came from kernel/sched/sched-pelt.h which was generated by Documentation/scheduler/sched-pelt. As the result, it causes compilation a lot of warnings, In file included from kernel/sched/pelt.h:2, from kernel/sched/rt.c:8: kernel/sched/sched-pelt.h:4:18: warning: 'runnable_avg_yN_inv' defined but not used [-Wunused-const-variable=] In file included from kernel/sched/pelt.h:2, from kernel/sched/fair.c:705: kernel/sched/sched-pelt.h:4:18: warning: 'runnable_avg_yN_inv' defined but not used [-Wunused-const-variable=] In file included from kernel/sched/pelt.h:2, from kernel/sched/deadline.c:19: kernel/sched/sched-pelt.h:4:18: warning: 'runnable_avg_yN_inv' defined but not used [-Wunused-const-variable=] Silence it by appending the __maybe_unused attribute for it, so all generated variables and macros can still be kept in the same file. Signed-off-by: Qian Cai --- v2: add a comment for __maybe_unused. Documentation/scheduler/sched-pelt.c | 3 ++- kernel/sched/sched-pelt.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/scheduler/sched-pelt.c b/Documentation/scheduler/sched-pelt.c index e4219139386a..7238b355919c 100644 --- a/Documentation/scheduler/sched-pelt.c +++ b/Documentation/scheduler/sched-pelt.c @@ -20,7 +20,8 @@ void calc_runnable_avg_yN_inv(void) int i; unsigned int x; - printf("static const u32 runnable_avg_yN_inv[] = {"); + /* To silence -Wunused-but-set-variable warnings. */ + printf("static const u32 runnable_avg_yN_inv[] __maybe_unused = {"); for (i = 0; i < HALFLIFE; i++) { x = ((1UL<<32)-1)*pow(y, i); diff --git a/kernel/sched/sched-pelt.h b/kernel/sched/sched-pelt.h index a26473674fb7..c529706bed11 100644 --- a/kernel/sched/sched-pelt.h +++ b/kernel/sched/sched-pelt.h @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0 */ /* Generated by Documentation/scheduler/sched-pelt; do not modify. */ -static const u32 runnable_avg_yN_inv[] = { +static const u32 runnable_avg_yN_inv[] __maybe_unused = { 0xffffffff, 0xfa83b2da, 0xf5257d14, 0xefe4b99a, 0xeac0c6e6, 0xe5b906e6, 0xe0ccdeeb, 0xdbfbb796, 0xd744fcc9, 0xd2a81d91, 0xce248c14, 0xc9b9bd85, 0xc5672a10, 0xc12c4cc9, 0xbd08a39e, 0xb8fbaf46, 0xb504f333, 0xb123f581, -- 1.8.3.1