From: guoren@kernel.org
To: marc.zyngier@arm.com, mark.rutland@arm.com, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net,
guoren@kernel.org, linux-csky@vger.kernel.org,
Guo Ren <ren_guo@c-sky.com>
Subject: [PATCH V4 4/4] irqchip/irq-csky-mpintc: Remove unnecessary loop in interrupt handler
Date: Tue, 4 Jun 2019 19:05:06 +0800 [thread overview]
Message-ID: <1559646306-18860-5-git-send-email-guoren@kernel.org> (raw)
In-Reply-To: <1559646306-18860-1-git-send-email-guoren@kernel.org>
From: Guo Ren <ren_guo@c-sky.com>
csky_mpintc_handler()
->handle_domain_irq()
->irq_exit()
->invoke_softirq()
->__do_softirq()
->local_irq_enable()
If new interrupt coming, it'll get into interrupt trap before return to
csky_mpintc_handler(). So there is no need loop in csky_mpintc_handler.
Signed-off-by: Guo Ren <ren_guo@c-sky.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>
---
drivers/irqchip/irq-csky-mpintc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/irqchip/irq-csky-mpintc.c b/drivers/irqchip/irq-csky-mpintc.c
index 2740dd5..122cd43 100644
--- a/drivers/irqchip/irq-csky-mpintc.c
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -75,11 +75,8 @@ static void csky_mpintc_handler(struct pt_regs *regs)
{
void __iomem *reg_base = this_cpu_read(intcl_reg);
- do {
- handle_domain_irq(root_domain,
- readl_relaxed(reg_base + INTCL_RDYIR),
- regs);
- } while (readl_relaxed(reg_base + INTCL_HPPIR) & BIT(31));
+ handle_domain_irq(root_domain,
+ readl_relaxed(reg_base + INTCL_RDYIR), regs);
}
static void csky_mpintc_enable(struct irq_data *d)
--
2.7.4
prev parent reply other threads:[~2019-06-04 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 11:05 [PATCH V4 0/4] irqchip/irq-csky-mpintc: Update some features guoren
2019-06-04 11:05 ` [PATCH V4 1/4] irqchip/irq-csky-mpintc: Add triger type guoren
2019-06-04 11:05 ` [PATCH V4 2/4] dt-bindings: interrupt-controller: Update csky mpintc guoren
2019-06-04 11:05 ` [PATCH V4 3/4] irqchip/irq-csky-mpintc: Support auto irq deliver to all cpus guoren
2019-06-04 11:54 ` Marc Zyngier
2019-06-04 12:32 ` Guo Ren
2019-06-04 11:05 ` guoren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559646306-18860-5-git-send-email-guoren@kernel.org \
--to=guoren@kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=ren_guo@c-sky.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome