From: Dan Carpenter <error27@gmail.com>
To: Dongliang Mu <dzm91@hust.edu.cn>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH linux-next v2 1/3] platform/x86/intel/tpmi: Fix double free in tpmi_create_device()
Date: Tue, 14 Mar 2023 17:22:28 +0300 [thread overview]
Message-ID: <155c581f-1a3e-4d6c-82b9-0ff7855dcaab@kili.mountain> (raw)
In-Reply-To: <20230309040107.534716-2-dzm91@hust.edu.cn>
On Thu, Mar 09, 2023 at 12:01:05PM +0800, Dongliang Mu wrote:
> The previous commit 6a192c0cbf38 ("platform/x86/intel/tpmi: Fix
> double free reported by Smatch") incorrectly handle the deallocation of
> res variable. As shown in the comment, intel_vsec_add_aux handles all
> the deallocation of res and feature_vsec_dev. Therefore, kfree(res) can
> still cause double free if intel_vsec_add_aux returns error.
>
> Fix this by adjusting the error handling part in tpmi_create_device,
> following the function intel_vsec_add_dev.
>
> Fixes: 6a192c0cbf38 ("platform/x86/intel/tpmi: Fix double free reported by Smatch")
> Signed-off-by: Dongliang Mu <dzm91@hust.edu.cn>
> ---
Yeah. These patches are right. The earlier fix still has a double
free. Devres stuff is confusing...
Reviewed-by: Dan Carpenter <error27@gmail.com>
regards,
dan carpenter
next prev parent reply other threads:[~2023-03-14 14:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230309040107.534716-1-dzm91@hust.edu.cn>
2023-03-09 4:01 ` Dongliang Mu
2023-03-14 14:22 ` Dan Carpenter [this message]
2023-03-16 14:25 ` Hans de Goede
2023-03-16 18:18 ` srinivas pandruvada
2023-03-17 1:28 ` Dongliang Mu
2023-03-17 8:51 ` Hans de Goede
2023-03-17 10:23 ` srinivas pandruvada
2023-03-17 11:57 ` Dongliang Mu
2023-03-17 10:27 ` srinivas pandruvada
2023-03-20 2:43 ` Dongliang Mu
2023-03-20 6:32 ` srinivas pandruvada
2023-03-20 10:32 ` Hans de Goede
2023-03-09 4:01 ` [PATCH linux-next v2 2/3] drivers/platform/x86/intel/tpmi: revise the comment of intel_vsec_add_aux Dongliang Mu
2023-03-20 10:33 ` Hans de Goede
2023-03-20 10:57 ` Dongliang Mu
2023-03-20 13:40 ` Hans de Goede
2023-03-09 4:01 ` [PATCH linux-next v2 3/3] drivers/platform/x86/intel: fix a memory leak in intel_vsec_add_aux Dongliang Mu
2023-03-20 10:31 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155c581f-1a3e-4d6c-82b9-0ff7855dcaab@kili.mountain \
--to=error27@gmail.com \
--cc=dzm91@hust.edu.cn \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®