From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 178C9188596 for ; Mon, 1 Jun 2026 05:17:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780291038; cv=none; b=X5//xfxlB8KgVPRigce6LcZPWRkGsFbaHBSfL55L4mL1Sq/yWP19pT2KNzjiWmuHJcDXHW5kfvyzvsyIPpE8Xa+F3y8MMkyuaAF8SPtB73hZHU2c0wU3vO1sXmk1/W4mT0SKjyJMXscIMiK62XgmBmd1AIsJ65mCPPclDOFXEQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780291038; c=relaxed/simple; bh=6gsGCN9fywOATamR24kEHpzEum26tdu1tLiSViwkxpY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WBS5jPOufOpRXI60+HY4/c+loiH+albNY5n8puAyYne1KwCQqBXay8qMihuFLHdLDSIxpKLDj6B+g3x72FYnU9hp8Rjck+xAdD/8HEv58Z1qmi4wgbB7GlR4FU2nnabTJr5XsDnWgMINx0KIoyVGX9+dKyjg2RyQIp2kpcpsMsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TfH4QDxN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NMDp2Z2A; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TfH4QDxN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NMDp2Z2A" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6511oJfD1069059 for ; Mon, 1 Jun 2026 05:17:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mhDV9pl06TXs/rs3qAQNP2Kc91MF0S9ipRtDBoJkiVI=; b=TfH4QDxN1b645pWo JhC33efiy8Mhk6eu/lAtEE9GPc7Txr07P07e/YmpdG9Jgi0PSqLxrqK8bS13NQdF YAJSbTuOmAtsIQ2108+RfZ+RyK0ODulz/VuVHIlusJlkYAs5wdSGOV+3EmvnJ4vc 2WMaO0eYwhPMRA9E8hA5xt/0Xce2mi61UJNX6wuHFqB+9rF8UoEbbMZd7zVK4DAe B9tiaFEsttDAqzx3cCsFVU4FvwaCr0WsoEWLiW3QgB/FMTSD8HBfxYbfHb3O9GAj nT6jhF2Y2bJ8bJclZ1Ex++GmsC7MjeK1uxOcDE9TmQpUbhwxrAMZi5FfLAPHaVgT oMdUnQ== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4efr98dp8n-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 01 Jun 2026 05:17:15 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2c0c36f1cc0so18962945ad.3 for ; Sun, 31 May 2026 22:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1780291035; x=1780895835; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mhDV9pl06TXs/rs3qAQNP2Kc91MF0S9ipRtDBoJkiVI=; b=NMDp2Z2AxHfDMPV1xJMWIin79HhPd0kIrd91Z0WlqURfa9trm73dZm2zzvZWNkk9RA 3x280SXhf8S3DVs9HqEtBidpVtUpu1tGKYYo5WQaLhKb/shC3KoFVhq94K8+XoN0c9BH 11zSxLlUPcd5fOygLDRQpmDAH61rVyt7EPHcZe/CSR+V84W6vZP7hsikjKDYwxkE28eG 4vHu+drPa0O2YWKTyybwAZYlQCrRFH4HdTKSULVy2ZtYW13/kFd9Fn7Bt+9ApnE5LtOS fgAamyEUZCx5gODuQZZTK/KtkrIFa7JABS15pEzB2/oI4jowBuTuCoYlxIfSTULJ+64E 9wJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780291035; x=1780895835; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mhDV9pl06TXs/rs3qAQNP2Kc91MF0S9ipRtDBoJkiVI=; b=MDmloTHUIa7dcas3PvtK8WM1hVsn2hdPZsKjoj22/ZwHYWBLiRcvdBKP2IEWJjX8KD sfo5n43cHO4Kbl+WQ6BNbJF/shRwXsh8CrL3YcWrXBrRxd2Y7R/Fr2p5vVmF9EfXLksK vY47PK65u4hclpOZEPqaQuhsOGG+ogyXb6DxXzq8kGjv/ct3Fh6fIkXFRcoHh4840sI+ ghcYtpdBRjAA0yY7b6mfWqZeYvQpmUIRrxoKZ4Vd3g/O1/wX7yT80JaZHUQxjyGzIv12 V8UeS2oSOqTAhiC2arOYdahFP2LyQC5SnJKMMboQ+wm2qH5sPTPqglFtCffv55U15fay 5fcA== X-Forwarded-Encrypted: i=1; AFNElJ+aBjowhkljNcMufGMrOHFYXR5qRiDCd7vxMPa41sTrtnR6UI2Rcbk9OvtcrPjxd9g5Bsgl/9+wJ7Nv9Vo=@vger.kernel.org X-Gm-Message-State: AOJu0Yze/kWopKAdPLei9GR5+oJi2NO/xRMHg6yLiibo54rQ+oAz8Jy6 AR43xd1zAVkyTxQ0PtTR1FoF6BhROjsrT6FSsh/5tpaYCguOi45ynw4VtIXk7G7gAEOJt0oeJP4 QaIgwQanO6vquQDBbWbprPr9n5bVe4+5VxqstLO5BIo84J43ifD4/TFN+1oBTUJLA5+A= X-Gm-Gg: Acq92OEPGMNZhpQWpqyqEwwFz9buQMN5tPQWXSAOmE2ltCxH71Y4TV4QVb3sRAiwTfL SS7/ZCkYFpJ4w8Yug/U/eFvpS/20EiF3Qzu7ATzXJIxH9yO0YHjT6WhQnq24kKE5zWZv3rH6xfj YN0bbU3FavKgCGjd8E7EmEBNnp24QJUj+ns3CA4QsyV/AQY/gm6Yd7UDNxG8Mhb9jS2EhoX38uw G1vjoQuDJnwgSuS2z9WUiXlD4ThcL7E4mfAxoK/X1l8nT/p0vpd0gNqc+8234CF4pxiw8SIHtzP XxHuZ9+NwjmC5VxUmxWNSgGyAAOCKUoEFSerIAw/DhrlyBVzu3t6GeSDjRQmiyNvUOsNHHktUgm PG+KAUF5sBUDOKr6I8X45jFFhYE4RIJQ7n6LOeIAzr42SXPs9+m8/PDcMF8/fzcL+l38NJGEZeI +hPoG8QzDdDdGsGkI02EOU6tg8 X-Received: by 2002:a17:902:ea07:b0:2bf:2e06:2ebf with SMTP id d9443c01a7336-2bf3685df7dmr109697385ad.31.1780291034862; Sun, 31 May 2026 22:17:14 -0700 (PDT) X-Received: by 2002:a17:902:ea07:b0:2bf:2e06:2ebf with SMTP id d9443c01a7336-2bf3685df7dmr109697055ad.31.1780291034415; Sun, 31 May 2026 22:17:14 -0700 (PDT) Received: from [10.133.33.84] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bf23b01727sm96486175ad.53.2026.05.31.22.17.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 31 May 2026 22:17:13 -0700 (PDT) Message-ID: <155c7b48-6fa6-4f25-8b0f-4e9081d5fadf@oss.qualcomm.com> Date: Mon, 1 Jun 2026 13:17:06 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] pinctrl: qcom: spmi-gpio: Rearchitect for flexible group support To: Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bartosz Golaszewski , David Collins , Subbaraman Narayanamurthy , Kamal Wadhwa , Maulik Shah , kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org References: <20260528-pinctrl-level-shifter-v2-0-3a6a025392bf@oss.qualcomm.com> <20260528-pinctrl-level-shifter-v2-3-3a6a025392bf@oss.qualcomm.com> <20260530-fervent-snobbish-silkworm-24ddae@quoll> Content-Language: en-US From: Fenglin Wu In-Reply-To: <20260530-fervent-snobbish-silkworm-24ddae@quoll> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=BaDoFLt2 c=1 sm=1 tr=0 ts=6a1d15db cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=43zHNb41aA7duc6R1F0A:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-GUID: a_VKfq8xmEsXn3-Mub-TnKia2VV2z3Fc X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjAxMDA1MSBTYWx0ZWRfX9ghnEcLmdjFM zoPdY13oLC5WdPDsJNcsFMKzEWga/BKhgARMmdq7Yjhm+GpKb53wP+IW7waVIorLvffzM8TLttQ HuMGrUUTYLH/4D4zG/ez+Uo7YORzolA13X8MKXaTYFbnSPMaexe2Oc7qQiEcl+rt1QVW/DADaCI 3JEGoq8460ifrMT1VPC6xnU+oOdaVwFHfJ4Xz9Ye5u40sxlaoi8wsS7ddwOuhTA5ZerkaZqx8B9 vaHvt2AIsiWvbhcLDJZRjwueRqyxhn00qLvyRTpa+6Z1RfrXJ6yI2RJljaVkRzl2yvT7NLBkYcj ZxLFNvGFS0YcuB/NJcMbXxAcKF4JMflXFphgoiT9nmZNxbzXni6Ka5rdk+pq3rG5KABA6xXJJzN 94/0MPmW2zMDh57MD5PAlw9AE5uMzDDZfLXb65H8e6RL1OmFR79plfKwNj6UXqNBDfeOP4juYyH GC0LNN3pT+b0hLv7BGA== X-Proofpoint-ORIG-GUID: a_VKfq8xmEsXn3-Mub-TnKia2VV2z3Fc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-01_01,2026-05-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 phishscore=0 malwarescore=0 impostorscore=0 adultscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605210000 definitions=main-2606010051 On 5/30/2026 6:31 PM, Krzysztof Kozlowski wrote: > On Thu, May 28, 2026 at 06:05:37PM -0700, Fenglin Wu wrote: >> Currently, the driver treats each pin as a group, and every pin or >> group can function correctly in all existing functions. However, >> this approach is no longer valid since some PMIC pins only operate >> together in specific functions, which are limited to certain GPIO >> groups. For example, in pmh0101, the level-shifter function is >> supported only between GPIO pairs like GPIO11/12, GPIO13/14, >> GPIO15/16, and GPIO17/18. >> >> To better accommodate these new functions and restrict GPIOs to >> those that support them, rearchitect the driver to enable flexible >> pinctrl group configurations by utilizing the generic pinctrl group >> and function APIs. >> >> Signed-off-by: Fenglin Wu >> --- >> drivers/pinctrl/qcom/Kconfig | 2 + >> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 377 +++++++++++++++++++++---------- > And now make this built-in and RPMH as module, then build it. Does > it build? Thanks. I missed to add the dependency in patch4 which really adds the rpmh control. I will update the Kconfig to make it depends on rpmh and cmd-db drivers. > Best regards, > Krzysztof >