From: Julien Thierry <julien.thierry@arm.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org,
marc.zyngier@arm.com, yuzenghui@huawei.com,
wanghaibin.wang@huawei.com, james.morse@arm.com,
will.deacon@arm.com, catalin.marinas@arm.com,
mark.rutland@arm.com, liwei391@huawei.com,
Julien Thierry <julien.thierry@arm.com>
Subject: [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes
Date: Tue, 11 Jun 2019 10:38:05 +0100 [thread overview]
Message-ID: <1560245893-46998-1-git-send-email-julien.thierry@arm.com> (raw)
Hi,
Version one[1] of this series attempted to fix the issue reported by
Zenghui[2] when using the function_graph tracer with IRQ priority
masking.
Since then, I realized that priority masking and the use of Pseudo-NMIs
was more broken than I thought.
* Patch 1-2 are just some cleanup
* Patch 3 fixes a potential issue with not clobbering condition flags
in irqflags operations
* Patch 4 fixes an issue where calling C code in Pseudo-NMI before
entering NMI enter could lead to potential races
* Patch 5 fixes the function_graph issue when using priority masking
* Patch 6 introduces some debug to hopefully avoid breaking things in
the future
* Patch 7 is a rebased version of the patch sent by Wei Li[3] fixing
an error that can happen during on some platform using the priority
masking feature
* Patch 8 re-enables the Pseudo-NMI selection
Changes since V3 [4]:
- Rebase on v5.2-rc4
- Fix comments/typos/missed updates
- Use single condition evalution for nmi_enter and nmi_exit
Changes since V2 [5]:
- Rebase on v5.2-rc3
- clobber conditions flags for asm that needs it as pointed out by Marc Z.
and Robin M.
- Fix the naming of the new PMR bit value
- Introduce some helper for the debug conditions
- use WARN_ONCE for debug that might be very noisy
- Reenable pseudo NMI.
Changes since V1 [1]:
- Fix possible race condition between NMI and trace irqflags
- Simplify the representation of PSR.I in the PMR value
- Include Wei Li's fix
- Rebase on v5.1-rc7
[1] https://marc.info/?l=linux-arm-kernel&m=155542458004480&w=2
[2] https://www.spinics.net/lists/arm-kernel/msg716956.html
[3] https://www.spinics.net/lists/arm-kernel/msg722171.html
[4] https://lkml.org/lkml/2019/6/6/280
[5] https://lkml.org/lkml/2019/4/29/643
Cheers,
Julien
-->
Julien Thierry (7):
arm64: Do not enable IRQs for ct_user_exit
arm64: irqflags: Pass flags as readonly operand to restore instruction
arm64: irqflags: Add condition flags to inline asm clobber list
arm64: Fix interrupt tracing in the presence of NMIs
arm64: Fix incorrect irqflag restore for priority masking
arm64: irqflags: Introduce explicit debugging for IRQ priorities
arm64: Allow selecting Pseudo-NMI again
Wei Li (1):
arm64: fix kernel stack overflow in kdump capture kernel
arch/arm64/Kconfig | 12 +++++-
arch/arm64/include/asm/arch_gicv3.h | 4 +-
arch/arm64/include/asm/cpufeature.h | 6 +++
arch/arm64/include/asm/daifflags.h | 75 +++++++++++++++++++++------------
arch/arm64/include/asm/irqflags.h | 79 +++++++++++++++++-----------------
arch/arm64/include/asm/kvm_host.h | 7 ++--
arch/arm64/include/asm/ptrace.h | 10 ++++-
arch/arm64/kernel/entry.S | 84 +++++++++++++++++++++++++++++--------
arch/arm64/kernel/irq.c | 26 ++++++++++++
arch/arm64/kernel/process.c | 2 +-
arch/arm64/kernel/smp.c | 6 +--
arch/arm64/kvm/hyp/switch.c | 2 +-
drivers/irqchip/irq-gic-v3.c | 7 ++++
kernel/irq/irqdesc.c | 8 +++-
14 files changed, 228 insertions(+), 100 deletions(-)
--
1.9.1
next reply other threads:[~2019-06-11 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 9:38 Julien Thierry [this message]
2019-06-11 9:38 ` [PATCH v4 1/8] arm64: Do not enable IRQs for ct_user_exit Julien Thierry
2019-06-11 12:45 ` Mark Rutland
2019-06-11 9:38 ` [PATCH v4 2/8] arm64: irqflags: Pass flags as readonly operand to restore instruction Julien Thierry
2019-06-11 12:46 ` Mark Rutland
2019-06-11 9:38 ` [PATCH v4 3/8] arm64: irqflags: Add condition flags to inline asm clobber list Julien Thierry
2019-06-11 12:52 ` Mark Rutland
2019-06-11 9:38 ` [PATCH v4 4/8] arm64: Fix interrupt tracing in the presence of NMIs Julien Thierry
2019-06-11 9:38 ` [PATCH v4 5/8] arm64: Fix incorrect irqflag restore for priority masking Julien Thierry
2019-06-11 9:38 ` [PATCH v4 6/8] arm64: irqflags: Introduce explicit debugging for IRQ priorities Julien Thierry
2019-06-11 9:38 ` [PATCH v4 7/8] arm64: fix kernel stack overflow in kdump capture kernel Julien Thierry
2019-06-11 9:38 ` [PATCH v4 8/8] arm64: Allow selecting Pseudo-NMI again Julien Thierry
2019-06-11 13:28 ` [PATCH v4 0/8] arm64: IRQ priority masking and Pseudo-NMI fixes Marc Zyngier
2019-06-21 10:27 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1560245893-46998-1-git-send-email-julien.thierry@arm.com \
--to=julien.thierry@arm.com \
--cc=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=rostedt@goodmis.org \
--cc=wanghaibin.wang@huawei.com \
--cc=will.deacon@arm.com \
--cc=yuzenghui@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®