From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 265A0C31E5B for ; Wed, 19 Jun 2019 17:48:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 008D5214AF for ; Wed, 19 Jun 2019 17:48:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="fMqNpV6g" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730342AbfFSRsL (ORCPT ); Wed, 19 Jun 2019 13:48:11 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:43752 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730259AbfFSRsI (ORCPT ); Wed, 19 Jun 2019 13:48:08 -0400 Received: by mail-qt1-f193.google.com with SMTP id w17so14569720qto.10 for ; Wed, 19 Jun 2019 10:48:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=dXV7QK2jBvzrpKqZ0H44fgbNkrbzKwjaMLPe99U+Pk0=; b=fMqNpV6gaqU3mDpG5fcUKQPTEEQa6ArYNQPiTQZxCa9HznA1vPxmBUT7ZednAsRb07 ELjqYp7VwmrsS6Tdc5aaPT6LwigvoioQ+AyxlYqz7ssKx+Qe5HVAeBLOoN8roZ7JIVkm oX8YYwHPfoWiaoTRzGFIOrfUgV74QegXaFy4FKbxkZfXv/wdx+y4LLatYy8BbELL94Mv Gt58clfIrnqHPMubWDqk1GCixWRgFB78LLU1pMqKb9VEr9/RuDncFLPjNZ7RpQFRdSDj Hs32oRB8WW4vkNQ9qij8Wgv/iImFxEqDILjQrpegAJbEjae0x10RvoyCfxN6ZpOfra8m zR2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=dXV7QK2jBvzrpKqZ0H44fgbNkrbzKwjaMLPe99U+Pk0=; b=Pjb0JAR1rGlLH+rcgTELKaVoBZ8RLxTn8VRh6EH7khiDgpbeTQWF/tDztoI4wzMBjH 6+vmXFA5FW+YAf0ghVhHj3xtegUXNStmYw0E8Qw3YGSJxoC+SMTG9XC+MVsipNnhYkGN IDnoeXCDBY5bZf9Qw1aV3TFEfMrQ8Npw13WPUSMrjWDyxtZlSKEzEhE6LX+cHkb5i5MY McuJuhxiQO++X2o59plSG9r7doiWI7KbL9keKEp4MAfOAudCa0GlazqS4jldBcUfc8Ou zyNgjPdwMqfdlFGfl/bpRTTt10k02UlqYAqYCM7w4oRF4GzqiZ/qkQTKQGI7w5aPOVir junQ== X-Gm-Message-State: APjAAAWKJ4iHdACbEDX/iBu++JjnusIJtBYIoNJLm0/Nj2a+V6GWxeXx T4Iw7mdBFLtciq0P/MKsrHf6LA== X-Google-Smtp-Source: APXvYqxywbv89LKe+7245WNQEyekTjsbFuLid+Nh9MmrzRaYzzhINqQ8eJdFHR8/g0lGeWI+UPJNQQ== X-Received: by 2002:ac8:2a69:: with SMTP id l38mr39177182qtl.212.1560966487512; Wed, 19 Jun 2019 10:48:07 -0700 (PDT) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id f25sm14278803qta.81.2019.06.19.10.48.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Jun 2019 10:48:07 -0700 (PDT) From: Qian Cai To: bp@alien8.de Cc: ard.biesheuvel@linaro.org, akpm@linux-foundation.org, dvhart@infradead.org, andy@infradead.org, tglx@linutronix.de, mingo@redhat.com, sai.praneeth.prakhya@intel.com, hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH v2] x86/efi: fix a -Wtype-limits compilation warning Date: Wed, 19 Jun 2019 13:47:44 -0400 Message-Id: <1560966464-27644-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Compiling a kernel with W=1 generates this warning, arch/x86/platform/efi/quirks.c:731:16: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits] Fixes: 3425d934fc03 ("efi/x86: Handle page faults occurring while running EFI runtime services") Signed-off-by: Qian Cai --- v2: Add a "Fixes" tag. arch/x86/platform/efi/quirks.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/platform/efi/quirks.c b/arch/x86/platform/efi/quirks.c index 632b83885867..3b9fd679cea9 100644 --- a/arch/x86/platform/efi/quirks.c +++ b/arch/x86/platform/efi/quirks.c @@ -728,7 +728,7 @@ void efi_recover_from_page_fault(unsigned long phys_addr) * Address range 0x0000 - 0x0fff is always mapped in the efi_pgd, so * page faulting on these addresses isn't expected. */ - if (phys_addr >= 0x0000 && phys_addr <= 0x0fff) + if (phys_addr <= 0x0fff) return; /* -- 1.8.3.1