From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86331C06510 for ; Mon, 1 Jul 2019 09:56:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EC77213F2 for ; Mon, 1 Jul 2019 09:56:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727814AbfGAJ4n (ORCPT ); Mon, 1 Jul 2019 05:56:43 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:18321 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727477AbfGAJ4n (ORCPT ); Mon, 1 Jul 2019 05:56:43 -0400 X-UUID: 73d37207a7e94239abcbabbd212a7df5-20190701 X-UUID: 73d37207a7e94239abcbabbd212a7df5-20190701 Received: from mtkcas09.mediatek.inc [(172.21.101.178)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1208537169; Mon, 01 Jul 2019 17:56:37 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Mon, 1 Jul 2019 17:56:36 +0800 Received: from [172.21.84.99] (172.21.84.99) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Mon, 1 Jul 2019 17:56:35 +0800 Message-ID: <1561974995.18866.1.camel@mtksdccf07> Subject: Re: [PATCH v3] kasan: add memory corruption identification for software tag-based mode From: Walter Wu To: Dmitry Vyukov CC: Andrey Ryabinin , Alexander Potapenko , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Matthias Brugger , "Martin Schwidefsky" , Arnd Bergmann , "Vasily Gorbik" , Andrey Konovalov , "Jason A . Donenfeld" , Miles Chen , kasan-dev , LKML , Linux-MM , Linux ARM , , wsd_upstream Date: Mon, 1 Jul 2019 17:56:35 +0800 In-Reply-To: <1560774735.15814.54.camel@mtksdccf07> References: <20190613081357.1360-1-walter-zh.wu@mediatek.com> <1560447999.15814.15.camel@mtksdccf07> <1560479520.15814.34.camel@mtksdccf07> <1560744017.15814.49.camel@mtksdccf07> <1560774735.15814.54.camel@mtksdccf07> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2019-06-17 at 20:32 +0800, Walter Wu wrote: > On Mon, 2019-06-17 at 13:57 +0200, Dmitry Vyukov wrote: > > On Mon, Jun 17, 2019 at 6:00 AM Walter Wu wrote: > > > > > > On Fri, 2019-06-14 at 10:32 +0800, Walter Wu wrote: > > > > On Fri, 2019-06-14 at 01:46 +0800, Walter Wu wrote: > > > > > On Thu, 2019-06-13 at 15:27 +0300, Andrey Ryabinin wrote: > > > > > > > > > > > > On 6/13/19 11:13 AM, Walter Wu wrote: > > > > > > > This patch adds memory corruption identification at bug report for > > > > > > > software tag-based mode, the report show whether it is "use-after-free" > > > > > > > or "out-of-bound" error instead of "invalid-access" error.This will make > > > > > > > it easier for programmers to see the memory corruption problem. > > > > > > > > > > > > > > Now we extend the quarantine to support both generic and tag-based kasan. > > > > > > > For tag-based kasan, the quarantine stores only freed object information > > > > > > > to check if an object is freed recently. When tag-based kasan reports an > > > > > > > error, we can check if the tagged addr is in the quarantine and make a > > > > > > > good guess if the object is more like "use-after-free" or "out-of-bound". > > > > > > > > > > > > > > > > > > > > > > > > > We already have all the information and don't need the quarantine to make such guess. > > > > > > Basically if shadow of the first byte of object has the same tag as tag in pointer than it's out-of-bounds, > > > > > > otherwise it's use-after-free. > > > > > > > > > > > > In pseudo-code it's something like this: > > > > > > > > > > > > u8 object_tag = *(u8 *)kasan_mem_to_shadow(nearest_object(cacche, page, access_addr)); > > > > > > > > > > > > if (access_addr_tag == object_tag && object_tag != KASAN_TAG_INVALID) > > > > > > // out-of-bounds > > > > > > else > > > > > > // use-after-free > > > > > > > > > > Thanks your explanation. > > > > > I see, we can use it to decide corruption type. > > > > > But some use-after-free issues, it may not have accurate free-backtrace. > > > > > Unfortunately in that situation, free-backtrace is the most important. > > > > > please see below example > > > > > > > > > > In generic KASAN, it gets accurate free-backrace(ptr1). > > > > > In tag-based KASAN, it gets wrong free-backtrace(ptr2). It will make > > > > > programmer misjudge, so they may not believe tag-based KASAN. > > > > > So We provide this patch, we hope tag-based KASAN bug report is the same > > > > > accurate with generic KASAN. > > > > > > > > > > --- > > > > > ptr1 = kmalloc(size, GFP_KERNEL); > > > > > ptr1_free(ptr1); > > > > > > > > > > ptr2 = kmalloc(size, GFP_KERNEL); > > > > > ptr2_free(ptr2); > > > > > > > > > > ptr1[size] = 'x'; //corruption here > > > > > > > > > > > > > > > static noinline void ptr1_free(char* ptr) > > > > > { > > > > > kfree(ptr); > > > > > } > > > > > static noinline void ptr2_free(char* ptr) > > > > > { > > > > > kfree(ptr); > > > > > } > > > > > --- > > > > > > > > > We think of another question about deciding by that shadow of the first > > > > byte. > > > > In tag-based KASAN, it is immediately released after calling kfree(), so > > > > the slub is easy to be used by another pointer, then it will change > > > > shadow memory to the tag of new pointer, it will not be the > > > > KASAN_TAG_INVALID, so there are many false negative cases, especially in > > > > small size allocation. > > > > > > > > Our patch is to solve those problems. so please consider it, thanks. > > > > > > > Hi, Andrey and Dmitry, > > > > > > I am sorry to bother you. > > > Would you tell me what you think about this patch? > > > We want to use tag-based KASAN, so we hope its bug report is clear and > > > correct as generic KASAN. > > > > > > Thanks your review. > > > Walter > > > > Hi Walter, > > > > I will probably be busy till the next week. Sorry for delays. > > It's ok. Thanks your kindly help. > I hope I can contribute to tag-based KASAN. It is a very important tool > for us. Hi, Dmitry, Would you have free time to discuss this patch together? Thanks. Walter