mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Greg Thelen <gthelen@google.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kbuild: clean compressed initramfs image
Date: Wed, 24 Jul 2019 11:40:00 +1000	[thread overview]
Message-ID: <1563932322.lqg59sj895.astroid@bobo.none> (raw)
In-Reply-To: <20190722063251.55541-1-gthelen@google.com>

Greg Thelen's on July 22, 2019 4:32 pm:
> Since commit 9e3596b0c653 ("kbuild: initramfs cleanup, set target from
> Kconfig") "make clean" leaves behind compressed initramfs images.
> Example:
>   $ make defconfig
>   $ sed -i 's|CONFIG_INITRAMFS_SOURCE=""|CONFIG_INITRAMFS_SOURCE="/tmp/ir.cpio"|' .config
>   $ make olddefconfig
>   $ make -s
>   $ make -s clean
>   $ git clean -ndxf | grep initramfs
>   Would remove usr/initramfs_data.cpio.gz
> 
> clean rules do not have CONFIG_* context so they do not know which
> compression format was used.  Thus they don't know which files to
> delete.
> 
> Tell clean to delete all possible compression formats.
> 
> Once patched usr/initramfs_data.cpio.gz and friends are deleted by
> "make clean".
> 
> Fixes: 9e3596b0c653 ("kbuild: initramfs cleanup, set target from Kconfig")
> Signed-off-by: Greg Thelen <gthelen@google.com>

Thanks for that, looks good to me.

Thanks,
Nick

      reply	other threads:[~2019-07-24  1:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22  6:32 Greg Thelen
2019-07-24  1:40 ` Nicholas Piggin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1563932322.lqg59sj895.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=gthelen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®