From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26A0EC433FF for ; Tue, 30 Jul 2019 21:24:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EA6BB20665 for ; Tue, 30 Jul 2019 21:24:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lca.pw header.i=@lca.pw header.b="ogU3+0aY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387716AbfG3VYH (ORCPT ); Tue, 30 Jul 2019 17:24:07 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:34737 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387649AbfG3VYH (ORCPT ); Tue, 30 Jul 2019 17:24:07 -0400 Received: by mail-qk1-f193.google.com with SMTP id t8so47651843qkt.1 for ; Tue, 30 Jul 2019 14:24:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lca.pw; s=google; h=from:to:cc:subject:date:message-id; bh=fLyVZXsTtfD1Xe1hWNe3oAIm1grhCSch4p5oOUN1k6U=; b=ogU3+0aYpayj2LlsZEQy0gKpRlrbB5anGsga45tY0zPJv18dr6xElrw7ZTngtw80F6 xAysXhDMZS3bSrqmwSLvz6/FdhW7uJMmZyeYt3DjhokEphewaFV+UQ387K5X72bVy1im 6+8r6GlpluXaC1iiYYq7j1gbDfb/a4BOM4dYFuTzjEUHBHtA1TgiUe5VJM9nslxIVzs2 lYByorPyXH6H3+znbp+YM9ydGqdJBRzz7LTEdmctUOc/14MRWpCTQq+w8WLhByAnmL3C 7TkvMkKta1s76Yk7Ocu3F9QstZWqfr1AM705WiFkgZwATc/GkJSAMH1tR8xeD8HZwDwS ubRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fLyVZXsTtfD1Xe1hWNe3oAIm1grhCSch4p5oOUN1k6U=; b=pA8MTaZazm6s7RnX/AkgrchrN5tdzBwFWb/HygjM0/kbfQsaoRIZr5Vfa3cB6wYqW0 dQ4xxKnZS7hdBASyu/EmZy4IyeQ9X//L7sYNUgl3PNmE5CXoKK9W9qe/Kg25PI6DVm6c 1/Ms3qiXdnXFvwBFAjEIue4yAw4Z6D8kW21kqlKyP0FeUVtRPxQwVER9E94Rwqg2aDU5 Ze6IxhjyNNnLeLbFLJQQQ2Cgk2VREdduR8hQPGrxCDpCAZY6Z2NAwy7Tu8ZtfGQSTHIC WbbOZOuI4e29GA8EOe8+EYbaFMhbcanUyfOGVa8QKBnrawSdnfzF+aR1XsZPEEhMJbMt /GHg== X-Gm-Message-State: APjAAAXgK4pDSinJKtadToc+4h9M+/16o1ugjYH2wXu3iNwAZlRjWJ2E GDvCw5psUqDHA7tckbnBL5ys2g== X-Google-Smtp-Source: APXvYqzGGzOl293rhLB2qxiR8WZ4xNszIZjsNseUBLKyYrY8Ml809POIZeuGW/8BcsF1e891maSxWg== X-Received: by 2002:a37:6243:: with SMTP id w64mr74090146qkb.444.1564521845978; Tue, 30 Jul 2019 14:24:05 -0700 (PDT) Received: from qcai.nay.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id q9sm26738659qkm.63.2019.07.30.14.24.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 30 Jul 2019 14:24:05 -0700 (PDT) From: Qian Cai To: ard.biesheuvel@linaro.org Cc: will@kernel.org, catalin.marinas@arm.com, linux-efi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Qian Cai Subject: [PATCH] arm64/efi: fix variable 'si' set but not used Date: Tue, 30 Jul 2019 17:23:48 -0400 Message-Id: <1564521828-4528-1-git-send-email-cai@lca.pw> X-Mailer: git-send-email 1.8.3.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GCC throws out this warning on arm64. drivers/firmware/efi/libstub/arm-stub.c: In function 'efi_entry': drivers/firmware/efi/libstub/arm-stub.c:132:22: warning: variable 'si' set but not used [-Wunused-but-set-variable] Fix it by making free_screen_info() a static inline function. Signed-off-by: Qian Cai --- arch/arm64/include/asm/efi.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/efi.h b/arch/arm64/include/asm/efi.h index 8e79ce9c3f5c..76a144702586 100644 --- a/arch/arm64/include/asm/efi.h +++ b/arch/arm64/include/asm/efi.h @@ -105,7 +105,11 @@ static inline unsigned long efi_get_max_initrd_addr(unsigned long dram_base, ((protocol##_t *)instance)->f(instance, ##__VA_ARGS__) #define alloc_screen_info(x...) &screen_info -#define free_screen_info(x...) + +static inline void free_screen_info(efi_system_table_t *sys_table_arg, + struct screen_info *si) +{ +} /* redeclare as 'hidden' so the compiler will generate relative references */ extern struct screen_info screen_info __attribute__((__visibility__("hidden"))); -- 1.8.3.1