From: <zhe.he@windriver.com>
To: <peterz@infradead.org>, <mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <jolsa@redhat.com>,
<namhyung@kernel.org>, <kan.liang@linux.intel.com>,
<eranian@google.com>, <alexey.budankov@linux.intel.com>,
<linux-kernel@vger.kernel.org>, <zhe.he@windriver.com>
Subject: [PATCH 2/2] perf: Fix writing to illegal memory in handling cpumap mask
Date: Fri, 2 Aug 2019 16:29:52 +0800 [thread overview]
Message-ID: <1564734592-15624-2-git-send-email-zhe.he@windriver.com> (raw)
In-Reply-To: <1564734592-15624-1-git-send-email-zhe.he@windriver.com>
From: He Zhe <zhe.he@windriver.com>
cpu_map__snprint_mask would write to illegal memory pointed by zalloc(0)
when there is only one cpu.
This patch fixes the calculation and adds sanity check against the input
parameters.
Signed-off-by: He Zhe <zhe.he@windriver.com>
---
tools/perf/util/cpumap.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/cpumap.c b/tools/perf/util/cpumap.c
index 3acfbe3..39cce66 100644
--- a/tools/perf/util/cpumap.c
+++ b/tools/perf/util/cpumap.c
@@ -751,7 +751,10 @@ size_t cpu_map__snprint_mask(struct cpu_map *map, char *buf, size_t size)
unsigned char *bitmap;
int last_cpu = cpu_map__cpu(map, map->nr - 1);
- bitmap = zalloc((last_cpu + 7) / 8);
+ if (buf == NULL)
+ return 0;
+
+ bitmap = zalloc(last_cpu / 8 + 1);
if (bitmap == NULL) {
buf[0] = '\0';
return 0;
--
2.7.4
next prev parent reply other threads:[~2019-08-02 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-02 8:29 [PATCH 1/2] perf: Fix failure to set cpumask when only one cpu zhe.he
2019-08-02 8:29 ` zhe.he [this message]
2019-08-08 13:36 ` [PATCH 2/2] perf: Fix writing to illegal memory in handling cpumap mask Arnaldo Carvalho de Melo
2019-08-08 20:19 ` [tip:perf/urgent] perf cpumap: " tip-bot for He Zhe
2019-08-02 13:06 ` [PATCH 1/2] perf: Fix failure to set cpumask when only one cpu Jiri Olsa
2019-08-03 5:34 ` He Zhe
2019-08-08 13:29 ` Arnaldo Carvalho de Melo
2019-08-08 20:18 ` [tip:perf/urgent] perf ftrace: Fix failure to set cpumask when only one cpu is present tip-bot for He Zhe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1564734592-15624-2-git-send-email-zhe.he@windriver.com \
--to=zhe.he@windriver.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexey.budankov@linux.intel.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®