From: Xinpeng Liu <danielliu861@gmail.com>
To: sumit.semwal@linaro.org, gustavo@padovan.org
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org,
Xinpeng Liu <danielliu861@gmail.com>
Subject: [PATCH] fence: checking for NULL pointer after dereferencing it.
Date: Wed, 7 Aug 2019 02:04:24 +0800 [thread overview]
Message-ID: <1565114664-10785-1-git-send-email-danielliu861@gmail.com> (raw)
drivers/dma-buf/dma-fence.c:131 in function dma_fence_signal_locked,
if (WARN_ON(!fence)) should be before lockdep_assert_held(fence->lock);
otherwise there is not any meaning.
Signed-off-by: Xinpeng Liu <danielliu861@gmail.com>
---
drivers/dma-buf/dma-fence.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/dma-buf/dma-fence.c b/drivers/dma-buf/dma-fence.c
index 59ac96e..0b11063 100644
--- a/drivers/dma-buf/dma-fence.c
+++ b/drivers/dma-buf/dma-fence.c
@@ -131,10 +131,9 @@ int dma_fence_signal_locked(struct dma_fence *fence)
struct dma_fence_cb *cur, *tmp;
int ret = 0;
- lockdep_assert_held(fence->lock);
-
if (WARN_ON(!fence))
return -EINVAL;
+ lockdep_assert_held(fence->lock);
if (test_and_set_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags)) {
ret = -EINVAL;
--
1.8.3.1
reply other threads:[~2019-08-06 18:04 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565114664-10785-1-git-send-email-danielliu861@gmail.com \
--to=danielliu861@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®