From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103DDC0650F for ; Thu, 8 Aug 2019 06:58:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E13E52184E for ; Thu, 8 Aug 2019 06:58:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731098AbfHHG6j (ORCPT ); Thu, 8 Aug 2019 02:58:39 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:55677 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726187AbfHHG6j (ORCPT ); Thu, 8 Aug 2019 02:58:39 -0400 X-UUID: bb2a2ddfaed84ef484bcb570e8928dcb-20190808 X-UUID: bb2a2ddfaed84ef484bcb570e8928dcb-20190808 Received: from mtkexhb02.mediatek.inc [(172.21.101.103)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0707 with TLS) with ESMTP id 2119135432; Thu, 08 Aug 2019 14:58:29 +0800 Received: from mtkcas08.mediatek.inc (172.21.101.126) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 8 Aug 2019 14:58:31 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas08.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 8 Aug 2019 14:58:30 +0800 Message-ID: <1565247511.29066.1.camel@mtkswgap22> Subject: Re: [PATCH v2] arm64: mm: print hexadecimal EC value in mem_abort_decode() From: Miles Chen To: Anshuman Khandual CC: Catalin Marinas , Will Deacon , , , , , Mark Rutland , James Morse Date: Thu, 8 Aug 2019 14:58:31 +0800 In-Reply-To: <256df022-6ad2-bae8-cc94-908adf409a07@arm.com> References: <20190807003336.28040-1-miles.chen@mediatek.com> <98bdbcfb-24ed-fcd8-4b2c-f2c78b245dda@arm.com> <1565244075.26350.3.camel@mtkswgap22> <256df022-6ad2-bae8-cc94-908adf409a07@arm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2019-08-08 at 11:51 +0530, Anshuman Khandual wrote: > > On 08/08/2019 11:31 AM, Miles Chen wrote: > > On Thu, 2019-08-08 at 11:19 +0530, Anshuman Khandual wrote: > >> > >> On 08/07/2019 06:03 AM, Miles Chen wrote: > >>> This change prints the hexadecimal EC value in mem_abort_decode(), > >>> which makes it easier to lookup the corresponding EC in > >>> the ARM Architecture Reference Manual. > >>> > >>> The commit 1f9b8936f36f ("arm64: Decode information from ESR upon mem > >>> faults") prints useful information when memory abort occurs. It would > >>> be easier to lookup "0x25" instead of "DABT" in the document. Then we > >>> can check the corresponding ISS. > >>> > >>> For example: > >>> Current info Document > >>> EC Exception class > >>> "CP15 MCR/MRC" 0x3 "MCR or MRC access to CP15a..." > >>> "ASIMD" 0x7 "Access to SIMD or floating-point..." > >>> "DABT (current EL)" 0x25 "Data Abort taken without..." > >>> ... > >>> > >>> Before: > >>> Unable to handle kernel paging request at virtual address 000000000000c000 > >>> Mem abort info: > >>> ESR = 0x96000046 > >>> Exception class = DABT (current EL), IL = 32 bits > >>> SET = 0, FnV = 0 > >>> EA = 0, S1PTW = 0 > >>> Data abort info: > >>> ISV = 0, ISS = 0x00000046 > >>> CM = 0, WnR = 1 > >>> > >>> After: > >>> Unable to handle kernel paging request at virtual address 000000000000c000 > >>> Mem abort info: > >>> ESR = 0x96000046 > >>> EC = 0x25: DABT (current EL), IL = 32 bits > >>> SET = 0, FnV = 0 > >>> EA = 0, S1PTW = 0 > >>> Data abort info: > >>> ISV = 0, ISS = 0x00000046 > >>> CM = 0, WnR = 1 > >>> > >>> Change since v1: > >>> print "EC" instead of "Exception class" > >>> print EC in fixwidth > >>> > >>> Cc: Mark Rutland > >>> Cc: Anshuman Khandual > >>> Cc: James Morse > >>> Signed-off-by: Miles Chen > >> > >> This version implements the suggestion, hence it should have > >> also contained acked-by tag from Mark from earlier version. > >> > > > > No problem. Sorry for not including the tag. > > I was not sure if I should add the acked-by tag from Mark in patch v2. > > Yeah because V2 has now implemented the suggestion as required for > getting the tag per Mark in V1. > Understood. thanks for the explanation > > > >> Reviewed-by: Anshuman Khandual > > > > If I send patch v3, I should include acked-by tag from Mark and > > Reviewed-by tag from you, right? > > Right.