From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752851AbeACOrv (ORCPT + 1 other); Wed, 3 Jan 2018 09:47:51 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:33489 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbeACOrm (ORCPT ); Wed, 3 Jan 2018 09:47:42 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20180103144738epoutp022c671f266871c32313caceaea5708e32~GVCjNlztQ1114211142epoutp02h X-AuditID: b6c32a46-9adff700000010ee-e6-5a4ced0a4738 From: Bartlomiej Zolnierkiewicz To: Mathieu Malaterre Cc: Tomi Valkeinen , Lennart Sorensen , Benjamin Herrenschmidt , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] Fix loading of module radeonfb on PowerMac Date: Wed, 03 Jan 2018 15:47:35 +0100 Message-id: <1565457.zQ5DZdIQMY@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20171221220757.24672-1-malat@debian.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42LZdljTQpfrrU+UwYSHwhYfmlqZLa58fc9m caLvA6vF5V1z2CxefFvDZHF201sWi/Xzb7E5sHt8XTWb3eNX21xmj543Lawe97uPM3kcv7Gd yePzJrkAtigum5TUnMyy1CJ9uwSujFfztjMVnFCoWDVvJ2MD42apLkZODgkBE4m/0++ydDFy cQgJ7GCUOLnjBiOE851RYuebrUxdjBxgVZse6kLEdzNKHGnZzAzhfGWUaFm/mBFkFJuAlcTE 9lVgtoiAhsStK8/ZQIqYBT4ATXq+HiwhLOAk8XXaVjCbRUBV4siLp2A2r4CmxK01c5hBbFEB L4kt+9qZQGxOATOJ1mPv2CFqBCV+TL7HAmIzC8hL7Ns/lRXC1pE4e2wd2NkSAifYJH6fOMAG 8ZyLxIeHf1khbGGJV8e3sEPY0hLPVm1khLCnM0ps/y0B0byZUWLV7glQRdYSh49fhNrAJ9Fx +C87JCx4JTrahCBKPCQ6Zq1mgbAdJZbN6WCHBMsBRomXTxaxTmCUnYXk8FlIDp+F5PAFjMyr GMVSC4pz01OLjQqM9IoTc4tL89L1kvNzNzGCU4aW2w7GJed8DjEKcDAq8fDeuOUTJcSaWFZc mXuIUYKDWUmE1y0LKMSbklhZlVqUH19UmpNafIhRmoNFSZy3NcAlSkggPbEkNTs1tSC1CCbL xMEp1cCYWC3bPu3ntnWxn75z3PtXe6mnPD37mlnztQUvzX/Oa2Swa3FquxD27tcV5rvPT0cs D5dRfnd9iaLbVcnNetVsoR9NjN8e6vHdxMlidf2Z/LY1ci+y9rPfFGbV6DvTuFEo58V3CfUF AfLuaet3FVVs7QifG/tOIirL2GJJ+PMD0wxt9k1L+bBeiaU4I9FQi7moOBEA0rdKpRUDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsVy+t9jAV3Otz5RBlNuWFt8aGpltrjy9T2b xYm+D6wWl3fNYbN48W0Nk8XZTW9ZLNbPv8XmwO7xddVsdo9fbXOZPXretLB63O8+zuRx/MZ2 Jo/Pm+QC2KK4bFJSczLLUov07RK4Ml7N285UcEKhYtW8nYwNjJuluhg5OCQETCQ2PdTtYuTi EBLYySix9XgfM4TzlVHi6Ou3TF2MnBxsAlYSE9tXMYLYIgIaEreuPGcDKWIW+MQosXHTWWaQ hLCAk8TXaVvBilgEVCWOvHgKZvMKaErcWjMHrEZUwEtiy752sKGcAmYSrcfesUNsO8Ao8b7x AxNEg6DEj8n3WEBsZgF5iX37p7JC2FoS63ceZ5rAyD8LSdksJGWzkJQtYGRexSiZWlCcm55b bFRglJdarlecmFtcmpeul5yfu4kRGOLbDmv172B8vCT+EKMAB6MSD++NWz5RQqyJZcWVuYcY JTiYlUR43bKAQrwpiZVVqUX58UWlOanFhxilOViUxHn5849FCgmkJ5akZqemFqQWwWSZODil GhiF577bf/hxfE7eLTul/XfFes2zPb3a9izaG/YyNjqkO26m3rtp6bNnV2nxK/efX8pwOW/V 6/JTZVtNltfPsyw0XRaolBa/oZb18PzrXX3Hm800fiRf5ngp8e8m81Gm+3vWXonzv5l6J632 jLWlf1Fny6P/4s7sU4VZfjPNYDMqshOpzNx/bq8SS3FGoqEWc1FxIgB7I6GVbQIAAA== X-CMS-MailID: 20180103144738epcas2p17c1325447a3139dd2c41b2b51ddf104f X-Msg-Generator: CA CMS-TYPE: 102P X-CMS-RootMailID: 20171221220824epcas3p1cd1ac40219c9b8bf7be52bc104e31918 X-RootMTR: 20171221220824epcas3p1cd1ac40219c9b8bf7be52bc104e31918 References: <1479153557-20849-1-git-send-email-malat@debian.org> <20171221220757.24672-1-malat@debian.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Thursday, December 21, 2017 11:07:56 PM Mathieu Malaterre wrote: > When the linux kernel is build with (typical kernel ship with Debian > installer): > > CONFIG_FB_OF=y > CONFIG_VT_HW_CONSOLE_BINDING=y > CONFIG_FB_RADEON=m > > The offb driver takes precedence over module radeonfb. It is then > impossible to load the module, error reported is: > > [ 96.551486] radeonfb 0000:00:10.0: enabling device (0006 -> 0007) > [ 96.551526] radeonfb 0000:00:10.0: BAR 0: can't reserve [mem 0x98000000-0x9fffffff pref] > [ 96.551531] radeonfb (0000:00:10.0): cannot request region 0. > [ 96.551545] radeonfb: probe of 0000:00:10.0 failed with error -16 > > This patch reproduce the behavior of the module radeon, so as to make it > possible to load radeonfb when offb is first loaded. > > It should be noticed that `offb_destroy` is never called which explain the > need to skip error detection on the radeon side. This still needs to be explained more, from my last mail: "The last put_fb_info() on fb_info should call ->fb_destroy (offb_destroy in our case) and remove_conflicting_framebuffers() is calling put_fb_info() so there is some extra reference on fb_info somewhere preventing it from going away. Please look into fixing this." > Signed-off-by: Mathieu Malaterre > Link: https://bugs.debian.org/826629#57 > Link: https://bugzilla.kernel.org/show_bug.cgi?id=119741 > Suggested-by: Lennart Sorensen > --- > v2: Only fails when CONFIG_PCC is not set > v3: Only fails when CONFIG_FB_OF is not set, CONFIG_PCC was too broad. Since the conflicts in region is due to OFfb explicitly refers to it. It seems that there may still be configurations when this is incorrect -> when offb drives primary (non-radeon) card and radeonfb drives secondary (radeon) card.. > drivers/video/fbdev/aty/radeon_base.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/drivers/video/fbdev/aty/radeon_base.c b/drivers/video/fbdev/aty/radeon_base.c > index 4d77daeecf99..221879196531 100644 > --- a/drivers/video/fbdev/aty/radeon_base.c > +++ b/drivers/video/fbdev/aty/radeon_base.c > @@ -2259,6 +2259,22 @@ static const struct bin_attribute edid2_attr = { > .read = radeon_show_edid2, > }; > > +static int radeon_kick_out_firmware_fb(struct pci_dev *pdev) > +{ > + struct apertures_struct *ap; > + > + ap = alloc_apertures(1); > + if (!ap) > + return -ENOMEM; > + > + ap->ranges[0].base = pci_resource_start(pdev, 0); > + ap->ranges[0].size = pci_resource_len(pdev, 0); > + > + remove_conflicting_framebuffers(ap, KBUILD_MODNAME, false); > + kfree(ap); > + > + return 0; > +} > > static int radeonfb_pci_register(struct pci_dev *pdev, > const struct pci_device_id *ent) > @@ -2312,19 +2328,27 @@ static int radeonfb_pci_register(struct pci_dev *pdev, > rinfo->fb_base_phys = pci_resource_start (pdev, 0); > rinfo->mmio_base_phys = pci_resource_start (pdev, 2); > > + ret = radeon_kick_out_firmware_fb(pdev); > + if (ret) > + return ret; > + > /* request the mem regions */ > ret = pci_request_region(pdev, 0, "radeonfb framebuffer"); > if (ret < 0) { > +#ifndef CONFIG_FB_OF > printk( KERN_ERR "radeonfb (%s): cannot request region 0.\n", > pci_name(rinfo->pdev)); > goto err_release_fb; > +#endif > } > > ret = pci_request_region(pdev, 2, "radeonfb mmio"); > if (ret < 0) { > +#ifndef CONFIG_FB_OF > printk( KERN_ERR "radeonfb (%s): cannot request region 2.\n", > pci_name(rinfo->pdev)); > goto err_release_pci0; > +#endif > } > > /* map the regions */ > @@ -2509,10 +2533,12 @@ static int radeonfb_pci_register(struct pci_dev *pdev, > iounmap(rinfo->mmio_base); > err_release_pci2: > pci_release_region(pdev, 2); > +#ifndef CONFIG_FB_OF > err_release_pci0: > pci_release_region(pdev, 0); > err_release_fb: > framebuffer_release(info); > +#endif > err_disable: > err_out: > return ret; Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics