From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C272519C556 for ; Tue, 28 Jan 2025 22:54:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738104849; cv=none; b=LlcjX5OHlmG4Ux3t0xAbocM10+4vivf2amOe87CSCOsQBOOg0uMQFPQJIg22J0soUJ8ABZJUigMlNZc5F8ujT41Z0gVC4N9DiQgNm8olTaAgJiBKUKtGbbfozxoWjOE93Yb/EMNv2kPHetWW/ApJpeAceJmCZaizdSgykoY+M0E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738104849; c=relaxed/simple; bh=KXl5PmXC5MpUncGASlvuVBQVU+9fSFmnhXYQyARvo6Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kRNh1saA2jpRpT6SbsEHTGVSoCCsISGtPEVLLYTCS/Jnxgy95XMIqolmYGQdAnECuQqDv5Rnu+8LL/RDgvGQ15eorunZ1di8u6ayO6XqnZ5L/bv0y/4RukSYpDsnGPPvXuxcnT2JL+KeHXZK23ufRACh+FI34yJm9RQxGVrSBEc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=MgDahsiH; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="MgDahsiH" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1738104844; bh=KXl5PmXC5MpUncGASlvuVBQVU+9fSFmnhXYQyARvo6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MgDahsiHyK9cai3sYTv1NwtPyjCBfmmUdJbJbw0XjSFYLS0il+LS71HRujNQo9Dta R+JRSFIZeyz26ebMK6O4uEeMgdkYF1tvDe1I1MFHPqAyzGGsEZKX2PG6MHqCQHfAjL uCr4szO7kIn5GW/GiV4yfYQFcxgSghyDAf38k6syHkfXFx8tyIwtEg71A4n+YyMGx8 Hla9fsvH8eOpyYTCmIZxUC6kUTXYD7FU9QJRfqFvxoVjkaaEJC4uXviN9AB7HpLnKL goBX/d4cso9RzKkQddiM4rR+tM461f4FQ0jERlnxfh+PzVP6sxhdKBicTLVKCD4vUZ Ne02ajWD6z7Lw== Received: from notapiano (unknown [IPv6:2804:14c:1a9:53ee::1004]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by bali.collaboradmins.com (Postfix) with ESMTPSA id 12D3717E0FD1; Tue, 28 Jan 2025 23:54:01 +0100 (CET) Date: Tue, 28 Jan 2025 19:53:59 -0300 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: "Rob Herring (Arm)" Cc: Lee Jones , Arnd Bergmann , Krzysztof Kozlowski , Pankaj Dubey , Will McVicker , John Madieu , Nishanth Menon , Vaishnav Achath , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: syscon: Restore device_node_to_regmap() for non-syscon nodes Message-ID: <15654ad7-1afb-41bf-afa9-c03c2bbb2cfa@notapiano> References: <20250124191644.2309790-1-robh@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250124191644.2309790-1-robh@kernel.org> On Fri, Jan 24, 2025 at 01:16:44PM -0600, Rob Herring (Arm) wrote: > Commit ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a > "syscon" compatible") broke drivers which call device_node_to_regmap() > on nodes without a "syscon" compatible. Restore the prior behavior for > device_node_to_regmap(). > > This also makes using device_node_to_regmap() incompatible with > of_syscon_register_regmap() again, so add kerneldoc for > device_node_to_regmap() and syscon_node_to_regmap() to make it clear > how and when each one should be used. > > Fixes: ba5095ebbc7a ("mfd: syscon: Allow syscon nodes without a "syscon" compatible") > Cc: Will McVicker > Cc: John Madieu > Cc: Nishanth Menon > Reported-by: Vaishnav Achath > Signed-off-by: Rob Herring (Arm) Still hitting this as of next-20250128. This patch fixed the issue which otherwise prevents boot on the Genio 700 EVK and Genio 1200 EVK boards. Tested-by: Nícolas F. R. A. Prado Thanks, Nícolas