From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751843AbaFOWrP (ORCPT ); Sun, 15 Jun 2014 18:47:15 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:62844 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751033AbaFOWrL (ORCPT ); Sun, 15 Jun 2014 18:47:11 -0400 From: "Rafael J. Wysocki" To: "H. Peter Anvin" Cc: Kees Cook , Pavel Machek , LKML , Randy Dunlap , Thomas Gleixner , Ingo Molnar , "x86@kernel.org" , Len Brown , Wei Yongjun , "linux-doc@vger.kernel.org" , linux-pm@vger.kernel.org Subject: Re: [PATCH 0/2] make kASLR vs hibernation boot-time selectable Date: Mon, 16 Jun 2014 01:04:42 +0200 Message-ID: <1565726.7T8Lt3Xc6J@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <539C7B2F.9070800@zytor.com> References: <1402602419-27934-1-git-send-email-keescook@chromium.org> <13135927.OjVm86GPrt@vostro.rjw.lan> <539C7B2F.9070800@zytor.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, June 14, 2014 09:41:19 AM H. Peter Anvin wrote: > On 06/13/2014 05:39 PM, Rafael J. Wysocki wrote: > > > > -#define RESTORE_MAGIC 0x0123456789ABCDEFUL > > +#define RESTORE_MAGIC 0x0123456789ABCDF0UL > > > > > > Please don't pick numbers like this for magic numbers... *everyone else > does, too.* In general, picking a random number is a good starting > point; for extra bonus make sure it has at least one invalid UTF-8 > sequence in it (so it cannot be confused with either ASCII or UTF-8 text.) > > OK, when we find out how to make hibernation work with the address space randomization. Rafael