From: Nicholas Piggin <npiggin@gmail.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Santosh Sivaraj <santosh@fossix.org>
Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>,
Reza Arbab <arbab@linux.ibm.com>,
Balbir Singh <bsingharora@gmail.com>,
Chandan Rajendra <chandan@linux.ibm.com>,
christophe leroy <christophe.leroy@c-s.fr>,
Mahesh Salgaonkar <mahesh@linux.ibm.com>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
stable@vger.kernel.org
Subject: Re: [PATCH v10 1/7] powerpc/mce: Schedule work from irq_work
Date: Tue, 20 Aug 2019 00:08:46 +1000 [thread overview]
Message-ID: <1566223307.ypgtanp5uk.astroid@bobo.none> (raw)
In-Reply-To: <20190815003941.18655-2-santosh@fossix.org>
Santosh Sivaraj's on August 15, 2019 10:39 am:
> schedule_work() cannot be called from MCE exception context as MCE can
> interrupt even in interrupt disabled context.
The powernv code doesn't do this in general, rather defers kernel
MCEs. My patch series converts the pseries machine check exception
code over to the same.
However there remain special cases where that's not true for
powernv, e.g., the machine check stack overflow or unrecoverable
MCE paths try to force it through so something gets printed. We
probably shouldn't even try to do memory failure in these cases.
Still, shouldn't hurt to make this change and fixes the existing
"different" pseries code.
Thanks,
Nick
> fixes: 733e4a4c ("powerpc/mce: hookup memory_failure for UE errors")
> Suggested-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> Signed-off-by: Santosh Sivaraj <santosh@fossix.org>
> Reviewed-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
> Acked-by: Balbir Singh <bsingharora@gmail.com>
> Cc: stable@vger.kernel.org # v4.15+
Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
next prev parent reply other threads:[~2019-08-19 14:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-15 0:39 [PATCH v10 0/7] powerpc: implement machine check safe memcpy Santosh Sivaraj
2019-08-15 0:39 ` [PATCH v10 1/7] powerpc/mce: Schedule work from irq_work Santosh Sivaraj
2019-08-19 14:08 ` Nicholas Piggin [this message]
2019-08-15 0:39 ` [PATCH v10 2/7] powerpc/mce: Fix MCE handling for huge pages Santosh Sivaraj
2019-08-19 14:22 ` Nicholas Piggin
2019-08-20 1:47 ` Santosh Sivaraj
2019-08-20 3:04 ` Nicholas Piggin
2019-08-15 0:39 ` [PATCH v10 3/7] powerpc/mce: Make machine_check_ue_event() static Santosh Sivaraj
2019-08-15 0:39 ` [PATCH v10 4/7] extable: Add function to search only kernel exception table Santosh Sivaraj
2019-08-15 0:39 ` [PATCH v10 5/7] powerpc/memcpy: Add memcpy_mcsafe for pmem Santosh Sivaraj
2019-08-15 0:39 ` [PATCH v10 6/7] powerpc/mce: Handle UE event for memcpy_mcsafe Santosh Sivaraj
2019-08-19 14:28 ` Nicholas Piggin
2019-08-15 0:39 ` [PATCH v10 7/7] powerpc: add machine check safe copy_to_user Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566223307.ypgtanp5uk.astroid@bobo.none \
--to=npiggin@gmail.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=arbab@linux.ibm.com \
--cc=bsingharora@gmail.com \
--cc=chandan@linux.ibm.com \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=santosh@fossix.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®