From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A21F8C3A59E for ; Sat, 24 Aug 2019 03:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CD022173B for ; Sat, 24 Aug 2019 03:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726566AbfHXDYp (ORCPT ); Fri, 23 Aug 2019 23:24:45 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:14951 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725924AbfHXDYp (ORCPT ); Fri, 23 Aug 2019 23:24:45 -0400 X-UUID: a0e4b519b90c46ff98dd02db7f03917e-20190824 X-UUID: a0e4b519b90c46ff98dd02db7f03917e-20190824 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0707 with TLS) with ESMTP id 1800538856; Sat, 24 Aug 2019 11:23:23 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs01n1.mediatek.inc (172.21.101.68) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sat, 24 Aug 2019 11:23:15 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sat, 24 Aug 2019 11:23:14 +0800 Message-ID: <1566617000.19935.7.camel@mhfsdcap03> Subject: Re: [PATCH v2] i2c: mediatek: disable zero-length transfers for mt8183 From: Qii Wang To: Hsin-Yi Wang CC: Wolfram Sang , Yingjoe Chen , Matthias Brugger , Nicolas Boichat , Jun Gao , Thomas Gleixner , , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , , lkml , Alexandru M Stan Date: Sat, 24 Aug 2019 11:23:20 +0800 In-Reply-To: References: <20190822094516.55130-1-hsinyi@chromium.org> <1566547772.19935.2.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2019-08-23 at 16:13 +0800, Hsin-Yi Wang wrote: > On Fri, Aug 23, 2019 at 4:09 PM Qii Wang wrote: > > > > > > > static u32 mtk_i2c_functionality(struct i2c_adapter *adap) > > > { > > > - return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > + if (adap->quirks->flags & I2C_AQ_NO_ZERO_LEN) > > > + return I2C_FUNC_I2C | > > > + (I2C_FUNC_SMBUS_EMUL & ~I2C_FUNC_SMBUS_QUICK); > > > + else > > > + return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL; > > > > It can be removed? > See previous discussion: https://patchwork.kernel.org/patch/10814391/#22484435 > but not all SoC's quirks has I2C_AQ_NO_ZERO_LEN. ok, it looks good for me, thanks. Reviewed-by: Qii Wang